chore(lint): enable clippy::unnested_or_patterns#168
Open
tupe12334 wants to merge 1 commit into
Open
Conversation
Promote clippy::unnested_or_patterns to deny in core/Cargo.toml, continuing the incremental clippy ratchet. Collapses repeated outer constructors in or-patterns (e.g. Some(1) | Some(2) -> Some(1 | 2)). Zero existing violations; clippy, build and tests pass. Closes #167 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes
clippy::unnested_or_patterns(pedantic group) todenyincore/Cargo.toml's[lints.clippy]table, continuing the repo's incremental clippy ratchet.What the lint catches
Or-patterns whose alternatives share the same outer constructor and can be collapsed into a single nested or-pattern:
Less repetition, clearer intent (the real variation moves to the inner level), and one-token extension when adding alternatives.
Changes
core/Cargo.toml: addunnested_or_patterns = "deny"to[lints.clippy].No source changes were needed — the codebase has zero violations today, so this is a clean forward guard.
Verification
cargo clippy --all-targets— passes (exit 0)cargo build— passescargo test— passes (15 tests + doc tests)Closes #167
This pull request was opened by the Clippy lint improvements → issue + PR (Rust repos) → Slack routine of moadim.