Enable clippy::enum_glob_use lint#166
Open
tupe12334 wants to merge 1 commit into
Open
Conversation
Add `enum_glob_use = "deny"` to the `[lints.clippy]` table in core/Cargo.toml. The lint bans glob imports of enum variants (`use MyEnum::*;`), favoring explicit variant paths. Complements the existing `wildcard_imports = "deny"` policy. Zero current violations; clippy/build/test all pass. Closes #165 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable
clippy::enum_glob_useCloses #165
Adds one line —
enum_glob_use = "deny"— to the[lints.clippy]table incore/Cargo.toml, continuing the crate's incremental lint ratchet.What the lint does
clippy::enum_glob_useflags glob imports of enum variants (use MyEnum::*;) and pushes toward explicit paths / named imports. This improves origin clarity at use sites and prevents variant-name collisions. It pairs naturally with the already-deniedclippy::wildcard_imports.Verification
cargo clippy --all-targets— passes (0 new violations)cargo build— passescargo test— passesNo source changes were needed; the tree is already clean, so this acts as a regression guard against future enum globs.
This pull request was opened by the Clippy lint improvements → issue + PR (Rust repos) → Slack routine of moadim.