Resolve FIXMEs#104
Merged
Merged
Conversation
Fills the API gaps between term and term_rcrd vectors (#90). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
`format.term()` now wraps terms containing backticks and escapes them so printed output is unambiguous (#90). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Remove `levels.term()` and `levels.term_rcrd()` workarounds now that vctrs (>= 0.4.0) implements `levels.vctrs_vctr()` (r-lib/vctrs#1186); `rbind()` behaviour remains covered by test-levels.R. - Remove the `pars(scalar = NA)` compatibility hack for nlist 0.1.0/0.1.1. - Import `as_list()` from extras instead of a local copy; move `par_pattern()` to internal.R. - Run `complete_terms()` term_rcrd examples (no longer \dontrun). - Lock in that zero-length dims yield no terms in `term()`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #90.
Resolves all ten FIXME comments:
set_pars.term_rcrd()andsummary.term_rcrd()are implemented, filling the API gaps with term vectors.format.term()now escapes embedded backticks so printed terms are unambiguous.levels.term()/levels.term_rcrd()workarounds are removed; vctrs (>= 0.4.0, now the declared minimum) implementslevels.vctrs_vctr()(Fix rbind() for vctrs_vctr with underlying type character r-lib/vctrs#1186 was fixed by levels.vctrs_vctr() returns NULL r-lib/vctrs#1478).rbind()behaviour remains covered by test-levels.R.pars(scalar = NA)hack for nlist 0.1.0/0.1.1 is removed; no reverse dependency passesscalar = NA.as_list()is imported from extras instead of a local copy (R/extras.Rdeleted;par_pattern()moved toR/internal.R).as.data.frame.term_rcrd()keepsdata.frame()withstringsAsFactorsfor base compatibility (question comment removed).complete_terms.term_rcrd()keeps the round-trip implementation; its examples now run (\dontrunremoved).term()with zero-length dims keeps returning no terms, now locked by a regression test.Verified: 569 tests pass under both dev and CRAN versions of chk and extras;
devtools::check()0 errors, 0 warnings, 0 notes;pkgdown::check_pkgdown()clean.🤖 Generated with Claude Code