Change tidy() default to simplify = TRUE#61
Merged
Conversation
The default value of simplify in tidy.nlists(), tidy.mcmc() and tidy.mcmc.list() is now TRUE, so default calls return the term, estimate, lower, upper and svalue columns without a deprecation warning. Explicit simplify = FALSE still returns the sd and zscore columns but remains warn-deprecated, matching the migration already completed for coef() in mcmcr 0.4.1 and embr 1.1.0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default value of
simplifyintidy.nlists(),tidy.mcmc()andtidy.mcmc.list()is nowTRUE, so default calls return the slim output (term,estimate,lower,upper,svalue) without the deprecation warning that previously fired on every default call. Explicitsimplify = FALSEstill works and returns the wide output withsdandzscorecolumns, but remains warn-deprecated.This follows the migration pattern already completed for
coef()in mcmcr 0.4.1 and embr 1.1.0. Staying at warn (rather thandeprecate_stop()) forsimplify = FALSEkeeps the released mcmcr working, sincetidy.mcmcr()passes its ownsimplify = FALSEdefault through explicitly; a companion mcmcr PR flips that default to match.simplify = FALSEcan progress todeprecate_stop()once the mcmcr release is out.simplify = FALSEexplicitly; a new test pins the default to the simplified output.simplifyparameter documentation notes thatFALSEis deprecated.tidy(directional_information = )soft-deprecation is unchanged.devtools::check(): 0 errors, 0 warnings, 0 notes. Tests: 461 passing (1 pre-existing skip).🤖 Generated with Claude Code