chore: allow custom testing application and test repo#573
Open
odockal wants to merge 2 commits into
Open
Conversation
serbangeorge-m
approved these changes
Jun 4, 2026
|
Warning Review limit reached
More reviews will be available in 56 minutes and 4 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThis PR parameterizes the e2e container infrastructure to run tests from any repository against any podman-desktop-based application, supporting multiple git providers. It refactors shared utilities, runner scripts, and documentation to accept configurable repo, application name, and git-provider parameters instead of hardcoded Podman Desktop assumptions. ChangesApplication and repository parameterization
Version updates and documentation
🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
pde2e-image/README.md (1)
331-331:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winVersion inconsistency in Extension Testing Example.
This example still references
v0.1.0while all other examples in this file were updated tov0.1.1. This inconsistency could confuse users and cause them to pull an outdated image version.🔧 Proposed fix
- quay.io/odockal/pde2e-image:v0.1.0-darwin \ + quay.io/odockal/pde2e-image:v0.1.1-darwin \🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pde2e-image/README.md` at line 331, Update the inconsistent image tag string "quay.io/odockal/pde2e-image:v0.1.0-darwin" to the current version "quay.io/odockal/pde2e-image:v0.1.1-darwin" so the Extension Testing Example matches the other examples; locate the occurrence of the exact image reference and replace the v0.1.0 tag with v0.1.1.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pde2e-image/common/unix/common.sh`:
- Around line 128-138: Quote all variable expansions and add error handling for
the directory change: use "$workingDir" in the cd and test expressions, quote
"$local_repo", "$local_git_provider_url" and "$local_fork" when building
repositoryURL, and check the exit status of cd (e.g., fail with an error log and
exit if cd "$workingDir" returns non-zero) so functions/variables like
workingDir, local_repo, local_git_provider_url, local_fork and repositoryURL are
used safely and cd failures are handled.
In `@pde2e-image/lib/darwin/runner.sh`:
- Around line 406-408: The script currently runs cd "$workingDir/$repo" after
clone_checkout without verifying success; if clone or checkout failed the script
continues in the wrong directory. After calling clone_checkout and before
proceeding, check that the target directory exists and that cd succeeds (e.g.,
test -d "$workingDir/$repo" and capture cd exit status), and if either check
fails call an error log and exit non‑zero; update the block around
clone_checkout, repo, workingDir and the cd command to perform these validations
and abort on failure.
- Around line 82-110: The if conditional uses an unquoted $debug which can lead
to word-splitting/globbing; in runner.sh update the check in the block starting
with if [ $debug == "1" ]; then to quote the variable and use a POSIX-safe
operator (e.g., if [ "$debug" = "1" ]; then) or switch to a bash test ([[
"$debug" == "1" ]]) so the debug variable is safely compared without
word-splitting.
- Around line 369-382: The script extracts version from pdUrl into the variable
version but doesn't validate it, so pdVolumePath search using "*${appName}
${version}*" can be malformed; modify runner.sh to check the extracted version
(variable version) immediately after the grep extraction (or use grep -q
beforehand), and if empty either (a) attempt a safe fallback find that searches
for volumes matching just "${appName}.app" or "${appName} *" explicitly, or (b)
fail fast with a clear error message referencing pdUrl and exit non‑zero; ensure
subsequent use of pdVolumePath and appName handles the chosen fallback/exit
path.
In `@pde2e-image/lib/windows/runner.ps1`:
- Around line 8-9: The parameter declaration for $resultsFolder in runner.ps1 is
marked Mandatory while also providing a default value "results"; remove the
contradiction by deleting the Mandatory attribute (or alternatively remove the
default if you intend it to be required). Update the
[Parameter(Mandatory,HelpMessage='Results folder')] line to
[Parameter(HelpMessage='Results folder')] (or drop the default assignment on
$resultsFolder) so the parameter metadata and the $resultsFolder default are
consistent.
In `@pde2e-image/README.md`:
- Line 177: The example URL in the README contains an embedded authentication
token (`?_auth_=1780583360_59f96afacf1215c49842f0911c8f0528`) which must be
removed; update the line containing the --pdUrl example so it uses a generic
placeholder (e.g.,
'https://access.cdn.redhat.com/<insert-your-download-url-here>' or similar) or
add a brief note directing users to obtain their own authenticated download URL
instead of embedding credentials directly in the example.
---
Outside diff comments:
In `@pde2e-image/README.md`:
- Line 331: Update the inconsistent image tag string
"quay.io/odockal/pde2e-image:v0.1.0-darwin" to the current version
"quay.io/odockal/pde2e-image:v0.1.1-darwin" so the Extension Testing Example
matches the other examples; locate the occurrence of the exact image reference
and replace the v0.1.0 tag with v0.1.1.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c880b343-24a1-4f8a-9c1f-6fa2d752e79e
📒 Files selected for processing (8)
pde2e-image/Makefilepde2e-image/README.mdpde2e-image/common/unix/common.shpde2e-image/common/windows/common.ps1pde2e-image/lib/darwin/runner.shpde2e-image/lib/windows/runner.ps1pde2e-image/tkn/task-rhel-display.yamlpde2e-image/tkn/task.yaml
Signed-off-by: Ondrej Dockal <odockal@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #572