Skip to content

Use local variables instead of recomputing#514

Merged
mernst merged 2 commits into
plume-lib:masterfrom
mernst:local-vars
May 31, 2026
Merged

Use local variables instead of recomputing#514
mernst merged 2 commits into
plume-lib:masterfrom
mernst:local-vars

Conversation

@mernst
Copy link
Copy Markdown
Contributor

@mernst mernst commented May 31, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 31, 2026

Review Change Stack

Warning

Review limit reached

@mernst, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 42 minutes and 48 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: d53ebcf0-2837-47e5-b457-be9d934f152c

📥 Commits

Reviewing files that changed from the base of the PR and between afb609d and 805fe9f.

📒 Files selected for processing (1)
  • src/main/java/org/plumelib/multiversioncontrol/MultiVersionControl.java
📝 Walkthrough

Walkthrough

This PR makes targeted refinements to MultiVersionControl.java affecting both directory-discovery logic and status-message output. The addCheckoutCvs method replaces its parent-traversal while loop with a for loop structure, and removeCommonSuffixDirs caches a parent-directory computation to improve its suffix-stripping loop. For Git and Mercurial status commands, the code updates message templates to reference the local dir variable directly rather than accessing the ProcessBuilder's directory through pb.directory().

Possibly related PRs

  • plume-lib/multi-version-control#424: Both PRs modify MultiVersionControl.java's repository-directory discovery logic in addCheckoutCvs(...) with related filesystem hierarchy navigation changes.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mernst mernst merged commit bc80daf into plume-lib:master May 31, 2026
6 checks passed
@mernst mernst deleted the local-vars branch May 31, 2026 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant