fix(papermc): fall back to SNAPSHOT form when metadata fetch rejects#41
Merged
Conversation
resolveApiVersion() handled non-2xx responses but let fetch's promise
rejection (DNS failure, offline, TLS) propagate. With folia.api() now
routed through this helper instead of the deterministic
${mc}-R0.1-SNAPSHOT coordinate it used before, an offline build that
could previously satisfy folia-api from the Maven cache started failing
on the metadata fetch.
Wrap the fetch in try/catch so the SNAPSHOT form falls through on any
network error, restoring offline-cached-build behaviour. Added unit
tests covering the four resolution paths (build-stamped hit, no match,
non-2xx, fetch reject).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
papermc.resolveApiVersionhandled!res.okbut letfetchrejections (DNS failure, offline, TLS) propagate. Since fix(platforms): make multi-platform builds work on latest MC versions #40 routedfolia.api()through this helper instead of the deterministic${mc}-R0.1-SNAPSHOTcoordinate Folia used before, an offline build that could previously satisfyfolia-apifrom the Maven cache started failing on the metadata fetch.try/catchso the SNAPSHOT form falls through on any network error, restoring offline-cached-build behaviour. Sponge's equivalent helper already had this shape; this brings the PaperMC helper in line.globalThis.fetch.Test plan
vp test src/platform/papermc/papermc.test.ts(6 passed)vp check