docs: bring the readme up to 2.3 - #50
Merged
Merged
Conversation
Linux is no longer built from source only: the release workflow ships a deb and an AppImage, x64 and arm64, so the download line and the Linux section said the wrong thing the moment a tag went out. macOS has a floor now and it was written nowhere. Electron 43 sets LSMinimumSystemVersion to 12.0, so Catalina and Big Sur cannot run 2.3, and 2.2.1 stays on the releases page for them. The two Linux permissions moved up to where someone installing would read them, and the dialout note caught up with the app: it offers to do it, and reads the group off the device rather than assuming the name. Cut the count of skipped specs on Windows. It was written by hand and the suite has grown past it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four things the readme claims that stop being true at the tag, and two that were already wrong.
Linux is no longer source-only. The release workflow builds an AppImage and a deb, x64 and arm64, so the download line and the whole Linux section were wrong the moment a tag went out.
macOS has a floor and it was written nowhere. Measured rather than assumed:
Electron 43 does not run on Catalina or Big Sur. 2.2.1 stays on the releases page for anyone there.
The two Linux permissions moved up to where someone installing would read them, rather than sitting at the bottom under Build It Yourself. Both say that Modbux offers to do it.
The dialout note caught up with the app. It reads the group off the device now rather than assuming the name, and it offers the logout that a group change needs.
Cut the count of skipped specs on Windows. It was written by hand and the suite has grown well past it. No number beats a wrong one.