fix: point the feature tour at the server it builds - #48
Merged
Conversation
The tour has been failing at scene 19 and taking the seventeen scenes after it with it, so half the manual's screenshots could not be refreshed. Act II builds registers through the add dialog to show the dialog, and left the simulator holding them, so Act III read a server that no longer matched the inverter the tour is named after. It reloads the config before the client connects now. Five scenes join it, all of them features with no picture: the strip over the toolbar with the grid filling underneath, which is what a scan looks like since the grid stopped being unmounted; a unit ID scan against a server holding two of the five IDs, so the results carry both answers; the poll rate and timeout; the word order table the BE/LE tooltip holds; and a column filter with the button that clears it.
The dialog fills the view anyway, and the strip of client behind it says nothing the manual needs.
Harted
force-pushed
the
fix/presentation-tour
branch
from
August 30, 2026 10:09
abcbe2c to
9aefcab
Compare
Harted
changed the title
Harted
marked this pull request as ready for review
August 30, 2026 10:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tour failed at scene 19 and took the seventeen scenes after it with it, so half the manual's screenshots could not be refreshed.
Act II builds registers through the add dialog in order to show the dialog, and left the simulator holding them. Act III then read a server that no longer matched the inverter the tour is named after, and asserted on values that were no longer there. It reloads the config before the client connects now, so every value from there on is the one the documented config describes.
Five scenes for features with no picture
The tour is 43 scenes and 58 screenshots now.