Skip to content

Explicitly enable XML-RPC in the WSGIServer layer. - #137

Merged
mauritsvanrees merged 1 commit into
masterfrom
maurits-enable-xmlrpc
Aug 6, 2026
Merged

Explicitly enable XML-RPC in the WSGIServer layer.#137
mauritsvanrees merged 1 commit into
masterfrom
maurits-enable-xmlrpc

Conversation

@mauritsvanrees

Copy link
Copy Markdown
Member

Zope 6.2 by default disables this.
But this is used in the WSGI_SERVER_FIXTURE that most robot tests (and acceptance tests) use. See plone/buildout.coredev#1108 (comment) and further.

An alternative would be to create a new layer and arrange it only here. But then we would need to change all packages with robot tests to use it.

I will test this in that coredev PR.

Zope 6.2 by default disables this.
But this is used in the ``WSGI_SERVER_FIXTURE`` that most robot tests (and acceptance tests) use.
See plone/buildout.coredev#1108 (comment) and further.
@mister-roboto

Copy link
Copy Markdown

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees added a commit to plone/buildout.coredev that referenced this pull request Aug 6, 2026
@mauritsvanrees

Copy link
Copy Markdown
Member Author

Now some Products.PluggableAuthService tests fail on Jenkins because they expect the new default of XML-RPC off. They use the ZopeLite layer. Somehow our change in the WSGI layer affects that, which is unexpected.

Well, those tests pass when run on their own, like on GitHub Actions, but they fail when we run a full PR test on Jenkins, which runs the tests of all specified packages.

Easiest is for me to change these three failing PAS tests so they pass whether run with Zope 6.1 or 6.2.

Meanwhile, let me test this small PR on its own:

@jenkins-plone-org please run jobs

@mauritsvanrees
mauritsvanrees merged commit 85d6850 into master Aug 6, 2026
13 checks passed
@mauritsvanrees
mauritsvanrees deleted the maurits-enable-xmlrpc branch August 6, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants