Skip to content

Products.ZCatalog = 7.2.1 in Plone 6.1 - #1073

Merged
davisagli merged 2 commits into
6.1from
Products.ZCatalog
Feb 24, 2026
Merged

Products.ZCatalog = 7.2.1 in Plone 6.1#1073
davisagli merged 2 commits into
6.1from
Products.ZCatalog

Conversation

@wesleybl

@wesleybl wesleybl commented Feb 21, 2026

Copy link
Copy Markdown
Member

Basically, what I'm looking for is this fix:

zopefoundation/Products.ZCatalog#159

Closes plone/Products.CMFPlone#3895

@wesleybl

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

@davisagli

Copy link
Copy Markdown
Member

Looks like there are 2 tests in plone.app.querystring that need to be updated, since the fix means there are now more results.

@wesleybl

Copy link
Copy Markdown
Member Author

It seems that @mauritsvanrees has already fixed this error in the master branch of plone.app.querystring:

plone/plone.app.querystring#171

I'll do a backport.

@wesleybl

wesleybl commented Feb 21, 2026

Copy link
Copy Markdown
Member Author

I make the PR in plone.app.querystring to fix the tests:

plone/plone.app.querystring#181

I then ran Jenkins with both PRs.

@wesleybl

Copy link
Copy Markdown
Member Author

I make the PR in plone.app.querystring to fix the tests:

plone/plone.app.querystring#181

I then ran Jenkins with both PRs.

The tests failed. It seems that it's not possible to run Jenkins with a PR from buildout.coredev and another from a different repository. Can anyone confirm this? @mauritsvanrees @davisagli @gforcada

What I can do is create a new PR in buildout.coredev that checkout my branch from plone.app.querystring.

@petschki

Copy link
Copy Markdown
Member

Unfortunately this is not possible, because there is this message in the jenkins console:

+ git checkout Products.ZCatalog
error: Your local changes to the following files would be overwritten by checkout:
	checkouts.cfg
Please commit your changes or stash them before you switch branches.
Aborting

so the first parameter changed the checkouts.cfg but the second parameter wants to checkout a different branch of buildout.coredev ... you could try to switch the parameters, so that the buildout PR is the first, and the querystring PR the second line ... not testet if this works ...

@wesleybl

Copy link
Copy Markdown
Member Author

... you could try to switch the parameters, so that the buildout PR is the first, and the querystring PR the second line ... not testet if this works ...

I don't remember the order in which I put them. I'll try again in that order.

Thanks!

@wesleybl

Copy link
Copy Markdown
Member Author

I'll try again in that order.

That order didn't work either. I'll create a new PR just to test the plone.app.querystring branch.

@wesleybl

Copy link
Copy Markdown
Member Author

When I run make run, constraints.txt is updated. Should I commit this?

@wesleybl

Copy link
Copy Markdown
Member Author

When I run make run, constraints.txt is updated. Should I commit this?

I updated it.

@davisagli

Copy link
Copy Markdown
Member

Merging based on the test results from #1074

@davisagli
davisagli merged commit 933aed3 into 6.1 Feb 24, 2026
12 of 14 checks passed
@davisagli
davisagli deleted the Products.ZCatalog branch February 24, 2026 04:15
@mauritsvanrees

Copy link
Copy Markdown
Member

Thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants