Chore/audit hardening#4
Merged
Merged
Conversation
Route invoice scanning through domain contracts/use cases, improve worker retry/offline fallback behavior, add androidTest smoke coverage in CI, and update ADR/docs to reflect the new security and quality baseline. Co-authored-by: Cursor <cursoragent@cursor.com>
Require signing secrets for release workflow builds, derive app versionCode from APP_VERSION_CODE in CI, remove debug-signing fallback for release, and update audit/readme documentation accordingly. Co-authored-by: Cursor <cursoragent@cursor.com>
Introduce domain/common Resource as a compatibility alias, keep existing util Resource behavior stable, and update architecture/audit documentation to track the incremental import migration plan. Co-authored-by: Cursor <cursoragent@cursor.com>
Return an explicit error for offline ID-based transaction filters (category/expense/contract), keep cache fallback for date/type/text-only queries, and update the audit progress notes. Co-authored-by: Cursor <cursoragent@cursor.com>
Introduce unit coverage for fresh cached overview reads and refresh-triggered invalidation/network fetch paths, and mark the related audit test-expansion item as completed. Co-authored-by: Cursor <cursoragent@cursor.com>
Switch domain repository contracts and non-pattern-matching use cases to import Resource from domain/common, keeping compatibility semantics intact and documenting the remaining migration scope. Co-authored-by: Cursor <cursoragent@cursor.com>
Extract failure classification into a testable helper, add unit coverage for retry/failure branches (IO, auth HTTP, server HTTP, unknown), and update audit progress for the worker test expansion. Co-authored-by: Cursor <cursoragent@cursor.com>
Move source/target preservation rules out of TransactionFormViewModel into a focused helper to reduce ViewModel responsibilities while preserving existing type-switch behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Move transaction payload building and optional metadata id resolution into dedicated helper functions to reduce TransactionFormViewModel responsibilities while keeping submit behavior unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
Move auto-classify status and state-merge logic into a focused helper file so TransactionFormViewModel keeps orchestration concerns while preserving behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Move source/target counterparty search state transitions into focused helper functions to simplify TransactionFormViewModel orchestration while preserving existing search behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Move transaction-to-form edit state mapping into a dedicated helper to reduce TransactionFormViewModel size while preserving edit initialization behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Move optional-section expansion decision logic into a focused helper so TransactionFormViewModel keeps reactive flow orchestration while preserving mode behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor after audting