Migrate to @playcanvas/eslint-config v3 (/typescript)#2076
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7 tasks
kpal81xd
force-pushed
the
eslint-config-v3
branch
from
57fc9b0 to
c394ea0
Compare
kpal81xd
force-pushed
the
eslint-config-v3
branch
from
c394ea0 to
8666cab
Compare
- add prettier.config.mjs re-exporting @playcanvas/eslint-config/prettier - add .prettierignore (sass stays owned by stylelint) - add fmt/fmt:fix scripts and prettier devDependency - rename type:check script to typecheck and update callers - ci: separate lint and fmt steps
kpal81xd
force-pushed
the
eslint-config-v3
branch
from
8666cab to
1a5bf3b
Compare
- format entire codebase with prettier (627 files) - fix ~1300 auto-fixable eslint errors (eslint --fix) - fix 688 mechanical rule violations across 241 files (prefer-for-of, no-prototype-builtins→Object.hasOwn, consistent-type-imports, typedef, no-unsafe-function-type, no-extraneous-class, etc.) - defer no-explicit-any and no-unused-vars to warn during migration - disable @typescript-eslint/no-unused-expressions for test files (chai) - bump tsconfig lib to es2023 (Node 22 LTS) for Object.hasOwn eslint: 0 errors | prettier: clean | build: passes | tests: 157 passing
kpal81xd
force-pushed
the
eslint-config-v3
branch
from
1a5bf3b to
253d16f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the v3 rollout: playcanvas/eslint-config#48 (Wave 4).
What changed
@playcanvas/eslint-config/typescriptand updated@playcanvas/eslint-configto3.0.0-beta.8.Object.hasOwnusage against the existing Chrome 63 production target.Migration status
no-explicit-anyandno-unused-varswarnings stay deferred for incremental follow-up.Manual smoke test
Expected: the editor loads without startup console errors.
Expected: the search controls update without
ReferenceError.Expected: launch loads and asset/entity sync paths do not throw ownership-check errors.