Skip to content

chore: use manager instead of config based helper#562

Open
OlegErshov wants to merge 5 commits into
mainfrom
chore/use-manager-instead-config-clients
Open

chore: use manager instead of config based helper#562
OlegErshov wants to merge 5 commits into
mainfrom
chore/use-manager-instead-config-clients

Conversation

@OlegErshov
Copy link
Copy Markdown
Contributor

Signed-off-by: OlegErshov olezhka1629@gmail.com

On-behalf-of: SAP aleh.yarshou@sap.com

@OlegErshov OlegErshov self-assigned this May 14, 2026
@github-actions github-actions Bot added the chore label May 14, 2026
@OlegErshov OlegErshov force-pushed the chore/use-manager-instead-config-clients branch from 9371ae0 to a3cd446 Compare May 14, 2026 15:34
@OlegErshov OlegErshov marked this pull request as ready for review May 14, 2026 15:39
@OlegErshov OlegErshov requested review from a team as code owners May 14, 2026 15:39
@simontesar
Copy link
Copy Markdown
Contributor

simontesar commented May 15, 2026

Is there a reason to not just use the ManagerKCPClientGetter implementation of the KCPClientGetter interface to keep things consistent?

@OlegErshov
Copy link
Copy Markdown
Contributor Author

No, ManagerKCPClientGetter might be used as well without any issue

OlegErshov and others added 4 commits May 15, 2026 14:41
Signed-off-by: OlegErshov <olezhka1629@gmail.com>

On-behalf-of: SAP aleh.yarshou@sap.com
Signed-off-by: OlegErshov <olezhka1629@gmail.com>
On-behalf-of: SAP aleh.yarshou@sap.com
Signed-off-by: OlegErshov <olezhka1629@gmail.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: OlegErshov <olezhka1629@gmail.com>
On-behalf-of: SAP aleh.yarshou@sap.com
Signed-off-by: OlegErshov <olezhka1629@gmail.com>
@OlegErshov OlegErshov force-pushed the chore/use-manager-instead-config-clients branch from b071e5c to 422d0a8 Compare May 15, 2026 12:41
@github-actions github-actions Bot added the fix label May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants