fix(security-operator): address AuthorizationModel StoreRef at the org's generated cluster#477
Open
ifdotpy wants to merge 2 commits into
Open
fix(security-operator): address AuthorizationModel StoreRef at the org's generated cluster#477ifdotpy wants to merge 2 commits into
ifdotpy wants to merge 2 commits into
Conversation
ifdotpy
changed the title
Signed-off-by: Igor Fominykh <ihor.fominykh@sap.com>
The StoreRef-cluster fix is generic to every provider; the test should read that way. Swap OpenKCM-specific identifiers (operations.openkcm.io / servicekeys / openkcm-provider workspace) for the stand-in example.io / widgets / providers:example so the intent is 'any provider APIBinding generates an AuthorizationModel addressed at the org GeneratedClusterId', not 'OpenKCM happens to break on cc-d2'. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Igor Fominykh <ihor.fominykh@sap.com>
ifdotpy
force-pushed
the
fix/openkcm-store-ref
branch
2 times, most recently
from
6214cb7 to
53b7d89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthorizationModelgeneration soStoreRef.Clusterpoints at the organization workspace'sGeneratedClusterId, notOriginClusterId.Organization.GeneratedClusterId.Why
StoreRefis used to find the KCP workspace that hosts the org's OpenFGAStore.OriginClusterIdis used in FGA tuple object strings; it is not the workspace logical cluster that owns the store.GeneratedClusterIdis the org workspace identity and is already the value used by the finalizer path when grouping bindings by organization.Scope
Minimal bug fix only:
AuthorizationModelGeneration.ProcessTesting
go test ./internal/subroutine -count=1task lintLocal full
task testwas attempted but this workstation has another process bound to:8080, which breaks the existing integration test manager startup. I did not include the test-harness metrics-port fix in this PR to keep scope minimal.