Honor file_identifier and root_type - #377
Open
kraln wants to merge 1 commit into
Open
Conversation
A schema's file_identifier is attached to its root_type table and exposed as an IDENTIFIER associated constant, alongside a new planus::buffer_has_identifier helper. Builder::finish is also fixed to write the identifier into bytes 4..8 after the root offset (the two were previously swapped, on an untested path) so identifier-bearing buffers match the official implementation. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A schema's file_identifier is attached to its root_type table and exposed as an IDENTIFIER associated constant, alongside a new planus::buffer_has_identifier helper. Builder::finish is also fixed to write the identifier into bytes 4..8 after the root offset (the two were previously swapped, on an untested path) so identifier-bearing buffers match the official implementation.
Addresses #141 and #55
Split out of !366
Checklist