Skip to content

Update undici #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshmgross merged 1 commit into from
Jun 3, 2026
Merged

Update undici #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 5 additions & 17 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"ts-jest": "^29.1.1",
"ts-node": "^10.9.1",
"typescript": "^5.1.6",
"undici": "^5.8.0"
"undici": "^8.3.0"

@cursor cursor Bot Jun 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need newer Node

Medium Severity

Upgrading the test-only undici devDependency to v8 makes npm test depend on Node >=22.19.0, because Jest imports undici in __tests__, while engines still allows Node >=16. Environments on Node 16–22.18 that satisfied engines and worked with undici v5 can fail when loading or running tests.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 3c2d0f8. Configure here.

@joshmgross joshmgross Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our tests are run with a newer version of Node, so I'm okay with this.

I do not want to stay on an old version of undici, but I don't want to unnecessarily bump the required version of Node for this package purely for a test dependency. It's likely that we should bump that to a newer version of Node that is LTS, but that's a separate discussion.

},
"eslintConfig": {
"extends": [
Expand Down
Loading