Conversation
ajnyga
force-pushed
the
f12392
branch
5 times, most recently
from
2b18cc3 to
c086e3b
Compare
blesildaramirez
left a comment
blesildaramirez
left a comment
There was a problem hiding this comment.
Hi @ajnyga , I've reviewed the frontend changes and left a few suggestions, mostly around standardizing the implementation. Please let me know if you have any questions or need any clarification. Thank you!
Thanks for the review @blesildaramirez, I've taken all your comments into account. |
|
Hi @ajnyga , just checking if you were able to push the changes. I'm not seeing the new commits or updates on my end yet. Thanks! |
|
Hi, @blesildaramirez was just waiting for an unresolved question in pkp-lib before pushing and starting the tests |
|
I'm not sure if it was discussed yet, but should the button ordering be changed here, with "Order" on the far left, to be similar to the contributors panel, and also have the arrows on the button? I think this also applies to Data Citations. I've also suggested a locale key change in Contributors panel: 
Current funding panel: 
|
|
The component used in Funders is a Manager, so not entirely the same as the panel component used with contributors. But let me know if we want to align these like @kaitlinnewson suggests. |
blesildaramirez
left a comment
blesildaramirez
left a comment
There was a problem hiding this comment.
Hi @ajnyga , thanks for addressing all my feedback - approved! However, please switch the ordering of the buttons as suggested by Kaitlin, so it'd be "Order" -> "Add a new Funder". The reasoning is that primary actions usually sit on the far right end, so the eye lands there last.
Also, adding the "Sort" icon would help - makes it clearer the button is for sorting.
Please feel free to merge once you've addressed the couple of items above. Thanks!
Also, thanks @kaitlinnewson - good catch on these!
3 participants
pkp/pkp-lib#12392