Allow PHPUnit 11 and 12 - #8
Merged
Merged
Conversation
The suite ran on the EOL PHPUnit 10.5 line. The constraint becomes ^11.5 || ^12.5: PHP 8.3+ resolves PHPUnit 12, while PHP 8.2 - still supported and CI-tested - stays on PHPUnit 11 (PHPUnit 12 requires PHP 8.3). phpunit.xml.dist already uses the shared 10/11/12 attribute subset and needs no changes. The one thing PHPUnit 12 flagged: the HTTP response provider test mocked Twig without configuring expectations - it is a stub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Dev-only:
phpunit/phpunitmoves from the EOL^10.5to^11.5 || ^12.5. Nothing changes for consumers of the plugin.Why the OR constraint: PHPUnit 12 requires PHP >= 8.3, while this plugin supports and CI-tests PHP 8.2. With the OR, PHP 8.3+ resolves PHPUnit 12.5 on highest deps, and PHP 8.2 (and every
--prefer-lowestleg) resolves PHPUnit 11.5 - the whole existing CI matrix keeps passing without workflow changes. PHPUnit 13 is deliberately not included yet (it would silently move the PHP 8.4/8.5 legs onto an unvetted major).phpunit.xml.distneeds no changes - it already uses the attribute subset shared by 10/11/12 (--migrate-configurationconfirms "does not need to be migrated"), and its schema reference tracks the installed version.Twig\Environmentmock created without expectations in the HTTP response provider test - now a stub, as it should have been.Verified
composer update --prefer-lowest --prefer-stable): 109 tests green. The lowest legs report vendor-caused risky warnings ("did not remove its own exception handlers" from the older Symfony error handler on functional tests) - cosmetic, non-failing, and unrelated to this change.phpstanlevel 9,ecs,behat --strict(15 scenarios) - green on both resolutions.