Keep the oneoff payload within EveryPay's field limits and reword the statement text - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mb_substrso multibyte letters count as characters. A truncated address still feeds fraud scoring; an over-long one could reject the whole request.order_referenceis transliterated and reduced to the charset the spec allows, with the order-number prefix capped at 100 characters (the Open Banking limit is 120). Sylius' default numeric order numbers pass untouched; the-{paymentId}suffix keeps the reference unique either way.{channel} ({number})instead of{channel} order {number}- a language-neutral noun phrase that also reads naturally when the platform prefixes the refund transfer's copy of it withRefund -. The 65-character cap now trims the channel name, never the order number.Companion to #9, which updates the distilled API reference these constraints come from.
Test plan
vendor/bin/phpunit- 111 tests greenvendor/bin/behat --strict- 15 scenarios greenvendor/bin/phpstan analyse(level 9) andvendor/bin/ecs check- clean🤖 Generated with Claude Code