Skip to content

[Issue #1379] fix Storage lifecycle and main index flush timing in index load path #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bianhq merged 1 commit into from
Aug 15, 2026
Merged

[Issue #1379] fix Storage lifecycle and main index flush timing in index load path #1380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions pixels-cli/src/main/java/io/pixelsdb/pixels/cli/load/IndexedPixelsConsumer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,8 @@ protected void processSourceFile(String originalFilePath) throws IOException, Me
}
}
}
originStorage.close();
// Do not close originStorage: StorageFactory caches one Storage instance per scheme, and the same
// instance is used by flushRemainingData() to write the data files when they share the scheme.
}

@Override
Expand Down Expand Up @@ -263,8 +264,6 @@ private void flushRowBatch(PerVirtualNodeWriter bucketWriter) throws IOException
queue.clear();
}
}
bucketWriter.indexService.flushIndexEntriesOfFile(index.getTableId(), index.getId(),
bucketWriter.currFile.getId(), true, bucketWriter.defaultIndexOption);
}

private void closePixelsFile(PerVirtualNodeWriter bucketWriter) throws IOException, IndexException
Expand All @@ -275,6 +274,10 @@ private void closePixelsFile(PerVirtualNodeWriter bucketWriter) throws IOExcepti
flushRowBatch(bucketWriter);
}

// The main index of a file can only be flushed once, hence it is flushed here instead of in flushRowBatch()
bucketWriter.indexService.flushIndexEntriesOfFile(index.getTableId(), index.getId(),
bucketWriter.currFile.getId(), true, bucketWriter.defaultIndexOption);

closeWriterAndAddFile(bucketWriter.pixelsWriter, bucketWriter.currFile, bucketWriter.currTargetPath, bucketWriter.targetNode);
}

Expand Down
Loading