fix: add missing responseTime parameter to customErrorMessage type#413
Open
antonisetkowicz wants to merge 1 commit into
Open
Conversation
The customErrorMessage callback receives 4 arguments at runtime (req, res, error, responseTime) but the TypeScript declaration only declared 3. This aligns the type with the actual call site at logger.js:128 and matches the pattern used by customSuccessMessage. Closes pinojs#359
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
customErrorMessagecallback receives 4 arguments at runtime (req,res,error,responseTime) in logger.js:128, but the TypeScript declaration inindex.d.tsonly declared 3 parameters — missingresponseTime: number.This is inconsistent with
customSuccessMessage, which already includesresponseTimein its type declaration.Changes
responseTime: numberparameter tocustomErrorMessagetyperesponseTimeparameter, updated combined options testVerification
tsd) passCloses #359