Skip to content

feat(web): extract appearance settings to a separate tab#2014

Closed
akarabach wants to merge 2 commits intopingdotgg:mainfrom
akarabach:feat/appearance-settings-tab
Closed

feat(web): extract appearance settings to a separate tab#2014
akarabach wants to merge 2 commits intopingdotgg:mainfrom
akarabach:feat/appearance-settings-tab

Conversation

@akarabach
Copy link
Copy Markdown
Contributor

@akarabach akarabach commented Apr 14, 2026

Summary

  • Extract Theme and Time format settings from the General tab into a new dedicated Appearance tab
  • Add PaletteIcon sidebar nav item between General and Connections
  • General tab retains all behavioral settings (diff wrapping, streaming, thread mode, confirmations, model, providers, etc.)
  • "Restore defaults" button continues to work across all tabs

Note: This is the first PR extracting appearance settings. I'm planning to move (and add) additional appearance-related settings in a follow-up PR.

Test plan

  • Verified Theme switching (system / light / dark) works from the new Appearance tab
  • Verified Time format switching (system default / 12-hour / 24-hour) works from the new Appearance tab
  • Verified "Restore defaults" button in the header correctly resets appearance settings across tabs
  • Verified General tab no longer shows Theme / Time format rows
  • Verified sidebar navigation highlights the active Appearance tab

Demo

Screenshot 2026-04-14 at 12 49 46 Screenshot 2026-04-14 at 12 49 38

Note

Low Risk
Primarily a UI re-organization with the same underlying setting writes; main risk is routing/nav wiring or regressions in the moved controls.

Overview
Adds a new Appearance settings section (/settings/appearance) and panel that hosts the existing Theme (system/light/dark) and Time format (locale/12-hour/24-hour) controls.

Updates settings navigation to include an Appearance tab (with PaletteIcon) and removes the Theme/Time format rows (and related constants/theme hook usage) from the General settings panel; the settings route tree is regenerated to register the new route.

Reviewed by Cursor Bugbot for commit faf108a. Bugbot is set up for automated code reviews on this repo. Configure here.

Move Theme and Time format settings from the General tab into a new
dedicated Appearance tab, improving settings discoverability.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 14, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b8ca66ac-841a-4f56-a4b2-bad862707f8f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 14, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Apr 14, 2026

Approvability

Verdict: Approved

This is a mechanical code extraction that moves existing appearance settings (theme and timestamp format) from the General settings panel to a new dedicated Appearance tab. The extracted code is unchanged - same constants, same hooks, same component structure. Only routing and navigation entries were added.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
Copy link
Copy Markdown
Member

This makes more sense to do when adding a proper appearance system

@akarabach
Copy link
Copy Markdown
Contributor Author

This makes more sense to do when adding a proper appearance system

didnt want to create xxxxl prs! reopened with font size settings, other appearance settings will do if the pr is fine #2174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants