feat(web): extract appearance settings to a separate tab#2014
feat(web): extract appearance settings to a separate tab#2014akarabach wants to merge 2 commits intopingdotgg:mainfrom
Conversation
Move Theme and Time format settings from the General tab into a new dedicated Appearance tab, improving settings discoverability.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved This is a mechanical code extraction that moves existing appearance settings (theme and timestamp format) from the General settings panel to a new dedicated Appearance tab. The extracted code is unchanged - same constants, same hooks, same component structure. Only routing and navigation entries were added. You can customize Macroscope's approvability policy. Learn more. |
|
This makes more sense to do when adding a proper appearance system |
didnt want to create xxxxl prs! reopened with font size settings, other appearance settings will do if the pr is fine #2174 |
Summary
PaletteIconsidebar nav item between General and ConnectionsTest plan
Demo
Note
Low Risk
Primarily a UI re-organization with the same underlying setting writes; main risk is routing/nav wiring or regressions in the moved controls.
Overview
Adds a new Appearance settings section (
/settings/appearance) and panel that hosts the existing Theme (system/light/dark) and Time format (locale/12-hour/24-hour) controls.Updates settings navigation to include an Appearance tab (with
PaletteIcon) and removes the Theme/Time format rows (and related constants/theme hook usage) from the General settings panel; the settings route tree is regenerated to register the new route.Reviewed by Cursor Bugbot for commit faf108a. Bugbot is set up for automated code reviews on this repo. Configure here.