dep: update pd client for batched runtime trace regions | tidb-test=release-8.5-20260323-v8.5.5#69857
Conversation
|
Skipping CI for Draft Pull Request. |
📝 WalkthroughWalkthroughTwo Go dependencies in ChangesGo dependency updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
52c98e6 to
a5480e3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.5-20260323-v8.5.5 #69857 +/- ##
================================================================
Coverage ? 54.9772%
================================================================
Files ? 1817
Lines ? 651522
Branches ? 0
================================================================
Hits ? 358189
Misses ? 266736
Partials ? 26597
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
a5480e3 to
a86ef8a
Compare
|
/retest |
[LGTM Timeline notifier]Timeline:
|
expxiaoli
left a comment
There was a problem hiding this comment.
Please run make bazel_prepare and commit the generated DEPS.bzl. Bazel still pins the old PD client, so release builds will miss this fix.
| github.com/tiancaiamao/appdash v0.0.0-20181126055449-889f96f722a2 | ||
| github.com/tikv/client-go/v2 v2.0.8-0.20260112052152-1d3c5ec76bf8 | ||
| github.com/tikv/pd/client v0.0.0-20260330105957-ebf9af006aac | ||
| github.com/tikv/pd/client v0.0.0-20260713030331-b294f28d9f6a |
There was a problem hiding this comment.
The new revision does not include ebf9af006aac, which fixed major Resource Group latency spikes. Please create a PD revision that contains both fixes.
|
/test mysql-test |
|
/test mysql-test |
a86ef8a to
bc7b455
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 114: Update the github.com/tikv/pd/client dependency pin in go.mod from
revision 4363de83f814 to the requested revision b294f28d9f6a, preserving the
existing pseudo-version format and dependency declaration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: cd8dcb40-3c29-4619-a49d-a53a1f21e599
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| github.com/tiancaiamao/appdash v0.0.0-20181126055449-889f96f722a2 | ||
| github.com/tikv/client-go/v2 v2.0.8-0.20260112052152-1d3c5ec76bf8 | ||
| github.com/tikv/pd/client v0.0.0-20260330105957-ebf9af006aac | ||
| github.com/tikv/pd/client v0.0.0-20260717021404-4363de83f814 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
tmp="$(mktemp -d)"
trap 'rm -rf "$tmp"' EXIT
git -C "$tmp" init -q
git -C "$tmp" remote add origin https://github.com/tikv/pd.git
git -C "$tmp" fetch -q --filter=blob:none --no-tags origin \
b294f28d9f6a 4363de83f814
git -C "$tmp" merge-base --is-ancestor \
FETCH_HEAD^{} 4363de83f814Repository: pingcap/tidb
Length of output: 261
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
repo=https://github.com/tikv/pd.git
# Inspect the remote refs that are definitely available.
git ls-remote --heads "$repo" | sed -n '1,20p'
# Check whether either hash is advertised by the remote.
git ls-remote "$repo" | awk '
$1 ~ /^b294f28d9f6a/ {print "matches target:", $0}
$1 ~ /^4363de83f814/ {print "matches pinned :", $0}
'Repository: pingcap/tidb
Length of output: 2040
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
tmp="$(mktemp -d)"
trap 'rm -rf "$tmp"' EXIT
git -C "$tmp" init -q
git -C "$tmp" remote add origin https://github.com/tikv/pd.git
# Fetch the specific refs that advertise the two commits.
git -C "$tmp" fetch -q --filter=blob:none --no-tags origin \
refs/heads/release-8.5-20260323-v8.5.5 \
refs/heads/release-8.5-20260709-v8.5.5 \
refs/tags/v8.5.5-20260713-b294f28
echo "Fetched commits:"
git -C "$tmp" rev-parse FETCH_HEAD^{commit}
git -C "$tmp" rev-parse origin/release-8.5-20260323-v8.5.5^{commit}
git -C "$tmp" rev-parse origin/release-8.5-20260709-v8.5.5^{commit}
git -C "$tmp" rev-parse origin/tags/v8.5.5-20260713-b294f28^{commit} 2>/dev/null || true
# Check ancestry: is b294... contained in 4363...?
git -C "$tmp" merge-base --is-ancestor \
origin/tags/v8.5.5-20260713-b294f28^{commit} \
origin/release-8.5-20260323-v8.5.5^{commit}
echo "ancestry: target is ancestor of pinned? $?"Repository: pingcap/tidb
Length of output: 477
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
tmp="$(mktemp -d)"
trap 'rm -rf "$tmp"' EXIT
git -C "$tmp" init -q
git -C "$tmp" remote add origin https://github.com/tikv/pd.git
git -C "$tmp" fetch -q --filter=blob:none --no-tags origin \
refs/heads/release-8.5-20260323-v8.5.5:refs/remotes/origin/pinned \
refs/heads/release-8.5-20260709-v8.5.5:refs/remotes/origin/target \
refs/tags/v8.5.5-20260713-b294f28:refs/tags/target-tag
pinned="$(git -C "$tmp" rev-parse refs/remotes/origin/pinned^{commit})"
target="$(git -C "$tmp" rev-parse refs/remotes/origin/target^{commit})"
tag="$(git -C "$tmp" rev-parse refs/tags/target-tag^{commit})"
printf 'pinned=%s\n' "$pinned"
printf 'target=%s\n' "$target"
printf 'tag =%s\n' "$tag"
if git -C "$tmp" merge-base --is-ancestor "$target" "$pinned"; then
echo "target is ancestor of pinned"
else
echo "target is NOT ancestor of pinned"
fi
if git -C "$tmp" merge-base --is-ancestor "$pinned" "$target"; then
echo "pinned is ancestor of target"
else
echo "pinned is NOT ancestor of target"
fiRepository: pingcap/tidb
Length of output: 422
Pin the requested PD revision go.mod currently points at 4363de83f814, which is a different commit from the PR objective’s b294f28d9f6a. Update the pin to the requested revision.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 114, Update the github.com/tikv/pd/client dependency pin in
go.mod from revision 4363de83f814 to the requested revision b294f28d9f6a,
preserving the existing pseudo-version format and dependency declaration.
What problem does this PR solve?
Issue Number: ref #69743
Problem Summary:
tikv/pd#10988has been merged intotikv/pdbranchrelease-8.5-20260709-v8.5.5. TiDB branchrelease-8.5-20260323-v8.5.5still depends on an oldergithub.com/tikv/pd/client, so it does not include the batched TSO runtime trace region fix.What changed and how does it work?
Update
github.com/tikv/pd/clientfromv0.0.0-20260330105957-ebf9af006aactov0.0.0-20260713030331-b294f28d9f6a, which corresponds to the merged PD release branch commitb294f28d9f6afromtikv/pd#10988.Check List
Tests
Side effects
Documentation
Tests run:
Release note
Summary by CodeRabbit