Skip to content

dep: update pd client for batched runtime trace regions | tidb-test=release-8.5-20260323-v8.5.5#69857

Open
bb7133 wants to merge 1 commit into
pingcap:release-8.5-20260323-v8.5.5from
bb7133:bb7133/pd-client-trace-region-release-8.5-20260323
Open

dep: update pd client for batched runtime trace regions | tidb-test=release-8.5-20260323-v8.5.5#69857
bb7133 wants to merge 1 commit into
pingcap:release-8.5-20260323-v8.5.5from
bb7133:bb7133/pd-client-trace-region-release-8.5-20260323

Conversation

@bb7133

@bb7133 bb7133 commented Jul 15, 2026

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: ref #69743

Problem Summary:

tikv/pd#10988 has been merged into tikv/pd branch release-8.5-20260709-v8.5.5. TiDB branch release-8.5-20260323-v8.5.5 still depends on an older github.com/tikv/pd/client, so it does not include the batched TSO runtime trace region fix.

What changed and how does it work?

Update github.com/tikv/pd/client from v0.0.0-20260330105957-ebf9af006aac to v0.0.0-20260713030331-b294f28d9f6a, which corresponds to the merged PD release branch commit b294f28d9f6a from tikv/pd#10988.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Tests run:

git diff --check
go test ./pkg/store/gcworker ./pkg/domain/infosync ./pkg/store/copr ./br/pkg/pdutil -run '^$' -count=1

Release note

None

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to newer versions to pick up the latest improvements and fixes.

@ti-chi-bot

ti-chi-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 15, 2026
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Two Go dependencies in go.mod, github.com/pingcap/kvproto and github.com/tikv/pd/client, are upgraded to newer pseudo-versions.

Changes

Go dependency updates

Layer / File(s) Summary
Update module versions
go.mod
The required github.com/pingcap/kvproto and github.com/tikv/pd/client versions are updated to newer pseudo-versions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Poem

A rabbit hops through modules bright,
Two dependencies take flight.
kvproto and PD renew,
With versions fresh and new.
Hop, hop, builds move along!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the pd client dependency update and the main purpose of the change.
Description check ✅ Passed The description covers the issue link, problem summary, change details, tests run, and release note in the expected template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 15, 2026
@pingcap-cla-assistant

pingcap-cla-assistant Bot commented Jul 15, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@bb7133
bb7133 force-pushed the bb7133/pd-client-trace-region-release-8.5-20260323 branch from 52c98e6 to a5480e3 Compare July 15, 2026 01:37
@bb7133
bb7133 marked this pull request as ready for review July 15, 2026 01:37
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2026
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-8.5-20260323-v8.5.5@5339e59). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-8.5-20260323-v8.5.5     #69857   +/-   ##
================================================================
  Coverage                               ?   54.9772%           
================================================================
  Files                                  ?       1817           
  Lines                                  ?     651522           
  Branches                               ?          0           
================================================================
  Hits                                   ?     358189           
  Misses                                 ?     266736           
  Partials                               ?      26597           
Flag Coverage Δ
integration 38.1399% <ø> (?)
unit 64.9744% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 55.4362% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bb7133
bb7133 force-pushed the bb7133/pd-client-trace-region-release-8.5-20260323 branch from a5480e3 to a86ef8a Compare July 15, 2026 02:41
@bb7133 bb7133 added type/bug The issue is confirmed as a bug. sig/sql-infra SIG: SQL Infra severity/minor labels Jul 16, 2026
@bb7133

bb7133 commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

/retest

D3Hunter
D3Hunter previously approved these changes Jul 16, 2026
@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 16, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-07-16 02:22:26.332727878 +0000 UTC m=+853132.368822934: ☑️ agreed by D3Hunter.

@expxiaoli expxiaoli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run make bazel_prepare and commit the generated DEPS.bzl. Bazel still pins the old PD client, so release builds will miss this fix.

Comment thread go.mod Outdated
github.com/tiancaiamao/appdash v0.0.0-20181126055449-889f96f722a2
github.com/tikv/client-go/v2 v2.0.8-0.20260112052152-1d3c5ec76bf8
github.com/tikv/pd/client v0.0.0-20260330105957-ebf9af006aac
github.com/tikv/pd/client v0.0.0-20260713030331-b294f28d9f6a

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new revision does not include ebf9af006aac, which fixed major Resource Group latency spikes. Please create a PD revision that contains both fixes.

@jebter jebter changed the title dep: update pd client for batched runtime trace regions dep: update pd client for batched runtime trace regions | tidb=release-8.5-20260323-v8.5.5 Jul 16, 2026
@jebter

jebter commented Jul 16, 2026

Copy link
Copy Markdown

/test mysql-test

@jebter jebter added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 16, 2026
@jebter jebter changed the title dep: update pd client for batched runtime trace regions | tidb=release-8.5-20260323-v8.5.5 dep: update pd client for batched runtime trace regions | tidb-test=release-8.5-20260323-v8.5.5 Jul 16, 2026
@jebter

jebter commented Jul 16, 2026

Copy link
Copy Markdown

/test mysql-test

@bb7133
bb7133 force-pushed the bb7133/pd-client-trace-region-release-8.5-20260323 branch from a86ef8a to bc7b455 Compare July 17, 2026 02:55
@ti-chi-bot

ti-chi-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign liuzix for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ti-chi-bot

ti-chi-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign liuzix for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@go.mod`:
- Line 114: Update the github.com/tikv/pd/client dependency pin in go.mod from
revision 4363de83f814 to the requested revision b294f28d9f6a, preserving the
existing pseudo-version format and dependency declaration.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: cd8dcb40-3c29-4619-a49d-a53a1f21e599

📥 Commits

Reviewing files that changed from the base of the PR and between a86ef8a and bc7b455.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Comment thread go.mod
github.com/tiancaiamao/appdash v0.0.0-20181126055449-889f96f722a2
github.com/tikv/client-go/v2 v2.0.8-0.20260112052152-1d3c5ec76bf8
github.com/tikv/pd/client v0.0.0-20260330105957-ebf9af006aac
github.com/tikv/pd/client v0.0.0-20260717021404-4363de83f814

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail
tmp="$(mktemp -d)"
trap 'rm -rf "$tmp"' EXIT
git -C "$tmp" init -q
git -C "$tmp" remote add origin https://github.com/tikv/pd.git
git -C "$tmp" fetch -q --filter=blob:none --no-tags origin \
  b294f28d9f6a 4363de83f814
git -C "$tmp" merge-base --is-ancestor \
  FETCH_HEAD^{} 4363de83f814

Repository: pingcap/tidb

Length of output: 261


🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

repo=https://github.com/tikv/pd.git

# Inspect the remote refs that are definitely available.
git ls-remote --heads "$repo" | sed -n '1,20p'

# Check whether either hash is advertised by the remote.
git ls-remote "$repo" | awk '
  $1 ~ /^b294f28d9f6a/ {print "matches target:", $0}
  $1 ~ /^4363de83f814/ {print "matches pinned :", $0}
'

Repository: pingcap/tidb

Length of output: 2040


🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

tmp="$(mktemp -d)"
trap 'rm -rf "$tmp"' EXIT

git -C "$tmp" init -q
git -C "$tmp" remote add origin https://github.com/tikv/pd.git

# Fetch the specific refs that advertise the two commits.
git -C "$tmp" fetch -q --filter=blob:none --no-tags origin \
  refs/heads/release-8.5-20260323-v8.5.5 \
  refs/heads/release-8.5-20260709-v8.5.5 \
  refs/tags/v8.5.5-20260713-b294f28

echo "Fetched commits:"
git -C "$tmp" rev-parse FETCH_HEAD^{commit}
git -C "$tmp" rev-parse origin/release-8.5-20260323-v8.5.5^{commit}
git -C "$tmp" rev-parse origin/release-8.5-20260709-v8.5.5^{commit}
git -C "$tmp" rev-parse origin/tags/v8.5.5-20260713-b294f28^{commit} 2>/dev/null || true

# Check ancestry: is b294... contained in 4363...?
git -C "$tmp" merge-base --is-ancestor \
  origin/tags/v8.5.5-20260713-b294f28^{commit} \
  origin/release-8.5-20260323-v8.5.5^{commit}
echo "ancestry: target is ancestor of pinned? $?"

Repository: pingcap/tidb

Length of output: 477


🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

tmp="$(mktemp -d)"
trap 'rm -rf "$tmp"' EXIT

git -C "$tmp" init -q
git -C "$tmp" remote add origin https://github.com/tikv/pd.git

git -C "$tmp" fetch -q --filter=blob:none --no-tags origin \
  refs/heads/release-8.5-20260323-v8.5.5:refs/remotes/origin/pinned \
  refs/heads/release-8.5-20260709-v8.5.5:refs/remotes/origin/target \
  refs/tags/v8.5.5-20260713-b294f28:refs/tags/target-tag

pinned="$(git -C "$tmp" rev-parse refs/remotes/origin/pinned^{commit})"
target="$(git -C "$tmp" rev-parse refs/remotes/origin/target^{commit})"
tag="$(git -C "$tmp" rev-parse refs/tags/target-tag^{commit})"

printf 'pinned=%s\n' "$pinned"
printf 'target=%s\n' "$target"
printf 'tag   =%s\n' "$tag"

if git -C "$tmp" merge-base --is-ancestor "$target" "$pinned"; then
  echo "target is ancestor of pinned"
else
  echo "target is NOT ancestor of pinned"
fi

if git -C "$tmp" merge-base --is-ancestor "$pinned" "$target"; then
  echo "pinned is ancestor of target"
else
  echo "pinned is NOT ancestor of target"
fi

Repository: pingcap/tidb

Length of output: 422


Pin the requested PD revision go.mod currently points at 4363de83f814, which is a different commit from the PR objective’s b294f28d9f6a. Update the pin to the requested revision.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 114, Update the github.com/tikv/pd/client dependency pin in
go.mod from revision 4363de83f814 to the requested revision b294f28d9f6a,
preserving the existing pseudo-version format and dependency declaration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. severity/minor sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug The issue is confirmed as a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants