Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions r/multi_query.result
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
set global tidb_enable_procedure = ON;
CREATE PROCEDURE multi_select()
BEGIN
SELECT 1;
SELECT 2, 3;
END//
CALL multi_select();
1
1
2 3
2 3
44 changes: 27 additions & 17 deletions src/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -953,15 +953,17 @@ func (rows *byteRows) Swap(i, j int) {
rows.data[i], rows.data[j] = rows.data[j], rows.data[i]
}

func dumpToByteRows(rows *sql.Rows) (*byteRows, error) {
cols, err := rows.Columns()
if err != nil {
return nil, errors.Trace(err)
}
func dumpToByteRows(rows *sql.Rows) ([]*byteRows, error) {
var result []*byteRows

data := make([]byteRow, 0, 8)
args := make([]interface{}, len(cols))
for {
cols, err := rows.Columns()
if err != nil {
return nil, errors.Trace(err)
}

data := make([]byteRow, 0, 8)
args := make([]interface{}, len(cols))
for rows.Next() {
tmp := make([][]byte, len(cols))
for i := 0; i < len(args); i++ {
Expand All @@ -974,16 +976,19 @@ func dumpToByteRows(rows *sql.Rows) (*byteRows, error) {

data = append(data, byteRow{tmp})
}

result = append(result, &byteRows{cols: cols, data: data})

if !rows.NextResultSet() {
break
}
}
err = rows.Err()
err := rows.Err()
if err != nil {
return nil, errors.Trace(err)
}

return &byteRows{cols: cols, data: data}, nil
return result, nil
}

func (t *tester) executeStmt(query string) error {
Expand All @@ -992,15 +997,20 @@ func (t *tester) executeStmt(query string) error {
if err != nil {
return errors.Trace(err)
}
defer raw.Close()

rows, err := dumpToByteRows(raw)
allRows, err := dumpToByteRows(raw)
if err != nil {
return errors.Trace(err)
}

if t.enableResultLog && (len(rows.cols) > 0 || len(rows.data) > 0) {
if err = t.writeQueryResult(rows); err != nil {
return errors.Trace(err)
if t.enableResultLog {
for _, rows := range allRows {
if len(rows.cols) > 0 || len(rows.data) > 0 {
if err = t.writeQueryResult(rows); err != nil {
return errors.Trace(err)
}
}
}
}

Expand All @@ -1023,14 +1033,14 @@ func (t *tester) executeStmt(query string) error {
return errors.Trace(err)
}

rows, err := dumpToByteRows(raw)
allRows, err := dumpToByteRows(raw)
if err != nil {
return errors.Trace(err)
}

if len(rows.data) > 0 {
sort.Sort(rows)
return t.writeQueryResult(rows)
if len(allRows) > 0 && len(allRows[0].data) > 0 {
sort.Sort(allRows[0])
return t.writeQueryResult(allRows[0])
}
}
return nil
Expand Down
12 changes: 12 additions & 0 deletions t/multi_query.test
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
set global tidb_enable_procedure = ON;
DELIMITER //

CREATE PROCEDURE multi_select()
BEGIN
SELECT 1;
SELECT 2, 3;
END//

DELIMITER ;

CALL multi_select();