Skip to content

Update perror code and regenerate perror.go#127

Open
dveeden wants to merge 1 commit into
pingcap:masterfrom
dveeden:perror_update
Open

Update perror code and regenerate perror.go#127
dveeden wants to merge 1 commit into
pingcap:masterfrom
dveeden:perror_update

Conversation

@dveeden
Copy link
Copy Markdown
Collaborator

@dveeden dveeden commented Jul 4, 2024

  • Better error messages
  • Updated error codes from MySQL 9.0.0
  • Using 'go generate' to create perror.go.

For CI:

  • This now actually runs the generation for perror.go in CI.
  • For this it also needs to checkout pingcap/tidb
  • It uses the Go version from go.mod instead of a hardcoded one

@dveeden dveeden requested review from bb7133 and mjonss July 4, 2024 11:59
mjonss
mjonss previously approved these changes Jul 4, 2024
Copy link
Copy Markdown
Collaborator

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with minor suggestion

Comment thread generate_perror/main.go Outdated
Comment thread src/perror.go
mjonss
mjonss previously approved these changes Jul 4, 2024
Copy link
Copy Markdown
Collaborator

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bb7133
bb7133 previously approved these changes Jul 8, 2024
Copy link
Copy Markdown
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dveeden dveeden marked this pull request as draft July 29, 2024 06:31
@dveeden dveeden marked this pull request as ready for review July 29, 2024 06:31
@dveeden dveeden closed this Jul 29, 2024
@dveeden dveeden reopened this Jul 29, 2024
@dveeden
Copy link
Copy Markdown
Collaborator Author

dveeden commented Jul 29, 2024

Not sure what's needed to get "license/cla" to report ✔️

@dveeden
Copy link
Copy Markdown
Collaborator Author

dveeden commented Jul 29, 2024

Not sure what's needed to get "license/cla" to report ✔️

https://cla.pingcap.net/pingcap/mysql-tester?pullRequest=127 says:


Error

There is no CLA to sign for pingcap/mysql-tester

(could not find linked item for owner pingcap and repo mysql-tester)


@dveeden dveeden dismissed stale reviews from bb7133 and mjonss via b7f0f63 May 22, 2026 13:32
@dveeden dveeden requested review from bb7133 and mjonss May 22, 2026 13:38
@dveeden
Copy link
Copy Markdown
Collaborator Author

dveeden commented May 22, 2026

PTAL @bb7133 @mjonss

Copy link
Copy Markdown
Collaborator

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants