Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions votes/0820-3AceShowHand-as-tidb-reviewer.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# A Vote for 3AceShowHand as TiDB Reviewer

## Proposal

[@3AceShowHand](https://github.com/3AceShowHand) has contributed to `pingcap/tidb` in several areas, including rowcodec, row-level checksum, DDL/CDC compatibility, BR, Lightning, and executor/planner work.

The following lists the details of his TiDB contributions:

- [16 merged authored pull requests](https://github.com/pingcap/tidb/pulls?q=is%3Apr+is%3Amerged+author%3A3AceShowHand)
- [15 authored issues](https://github.com/pingcap/tidb/issues?q=is%3Aissue+author%3A3AceShowHand)
- [14 merged pull requests reviewed for other authors](https://github.com/pingcap/tidb/pulls?q=is%3Apr+is%3Amerged+reviewed-by%3A3AceShowHand+-author%3A3AceShowHand)

Representative work includes:

- Row-level checksum and rowcodec changes: [#50896](https://github.com/pingcap/tidb/pull/50896), [#52511](https://github.com/pingcap/tidb/pull/52511), [#53931](https://github.com/pingcap/tidb/pull/53931), [#57139](https://github.com/pingcap/tidb/pull/57139), [#57205](https://github.com/pingcap/tidb/pull/57205)
- BR and Lightning improvements: [#48453](https://github.com/pingcap/tidb/pull/48453), [#57706](https://github.com/pingcap/tidb/pull/57706)
- Executor/planner and expression fixes: [#20233](https://github.com/pingcap/tidb/pull/20233), [#20960](https://github.com/pingcap/tidb/pull/20960), [#21095](https://github.com/pingcap/tidb/pull/21095), [#21306](https://github.com/pingcap/tidb/pull/21306)

He has also reviewed TiDB changes in related areas, such as row-level checksum and domain changes: [#42859](https://github.com/pingcap/tidb/pull/42859), [#43141](https://github.com/pingcap/tidb/pull/43141), [#43163](https://github.com/pingcap/tidb/pull/43163), [#43479](https://github.com/pingcap/tidb/pull/43479), [#57200](https://github.com/pingcap/tidb/pull/57200).

I ([@YuJuncen](https://github.com/YuJuncen)) hereby nominate [@3AceShowHand](https://github.com/3AceShowHand) as TiDB Reviewer and call for a vote.

## Deadline

The vote will be open for at least 3 days unless there is an objection or not enough votes.

## Scope

* Team TiDB

## Result

See also https://github.com/pingcap/community/pull/822.