fix: return self::FAILURE from CleanupUnusedIndicesCommand on exception#441
Closed
Copilot wants to merge 2 commits into
Closed
fix: return self::FAILURE from CleanupUnusedIndicesCommand on exception#441Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comment
fix: return self::FAILURE from CleanupUnusedIndicesCommand on exception
Jun 23, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




When an exception was caught in
CleanupUnusedIndicesCommand::execute(), the command printed the error but still exited0, making failures invisible to automation (cron, CI, K8s jobs).Change
catchblock now returnsself::FAILUREafter writing the error messagefinallystill runs unconditionally, so the lock is always released