[Bug] Stabilize class mapping checksum across array key order#419
Draft
mcop1 wants to merge 2 commits into
Draft
[Bug] Stabilize class mapping checksum across array key order#419mcop1 wants to merge 2 commits into
mcop1 wants to merge 2 commits into
Conversation
Recursively sort associative array keys before hashing the class mapping so that PHP insertion order changes do not produce a different checksum, which would otherwise trigger spurious reindex runs for unchanged class definitions.
The setup-matrix job was using the default checkout (merge commit), which reads composer.json from the base branch. The reusable codeception workflow checks out the PR head ref instead. When the base branch allows a newer PHP version (e.g. 8.5) that the PR branch does not support, the matrix includes PHP versions incompatible with the PR's composer.json, causing composer to fail. Pin the setup-matrix checkout to the PR head sha so both jobs use the same composer.json and the generated matrix matches the code being tested.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recursively sort associative array keys before hashing the class mapping so that PHP insertion order changes do not produce a different checksum, which would otherwise trigger spurious reindex runs for unchanged class definitions.