cleanup: replace is-promise with instanceof Promise check#202
Closed
maksim-romanov wants to merge 1 commit into
Closed
cleanup: replace is-promise with instanceof Promise check#202maksim-romanov wants to merge 1 commit into
is-promise with instanceof Promise check#202maksim-romanov wants to merge 1 commit into
Conversation
|
Duplicate of #137 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native Promises are universally supported, so the
is-promisedependencycan be replaced with a strict
instanceof Promisecheck. The deprecationblock added in #154 becomes unreachable but is left in place so this PR
stays minimal — it can be removed in a follow-up.
Closes #136