Skip to content

fix: sync hostname after import#2

Open
kacpersaw wants to merge 1 commit intopigmej:mainfrom
kacpersaw:kacpersaw/fix-import-hostname-sync
Open

fix: sync hostname after import#2
kacpersaw wants to merge 1 commit intopigmej:mainfrom
kacpersaw:kacpersaw/fix-import-hostname-sync

Conversation

@kacpersaw
Copy link
Copy Markdown
Contributor

Summary

  • sync the guest hostname to the imported container name after ocdev import starts the container
  • verify the hostname update succeeds so failed imports still follow the existing cleanup path
  • document that import rewrites host-specific ports, mounts, and hostname

Validation

  • PATH=\"/Users/kacper/.nimble/bin:$PATH\" make bin/ocdev
  • PATH=\"/Users/kacper/.nimble/bin:$PATH\" nim c -r cmd/ocdev/tests/test_all.nim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant