Skip to content

[diffs/editor] refactor editor API #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ije wants to merge 1 commit into
base: beta-1.3
Choose a base branch
from
+308 −168
Draft

[diffs/editor] refactor editor API #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/diffs/src/components/File.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ export class File<
const file = this.file;
if (fileContainer != null && file != null) {
void this.fileRenderer.initializeHighlighter().then((highlighter) => {
editor.syncToRenderedView(
editor.__resetEditState(
highlighter,
fileContainer,
file,
Expand Down Expand Up @@ -529,7 +529,7 @@ export class File<

// postpone background tokenizing to next frame for avoiding UI freeze
// during render
this.editor?.postponeBackgroundTokenizeToNextFrame();
this.editor?.__postponeBackgroundTokenizeToNextFrame();

const { collapsed = false, themeType = 'system' } = this.options;
const nextRenderRange = collapsed ? undefined : renderRange;
Expand Down Expand Up @@ -659,7 +659,7 @@ export class File<
const editor = this.editor;
if (editor != null) {
void this.fileRenderer.initializeHighlighter().then((highlighter) => {
editor.syncToRenderedView(
editor.__resetEditState(
highlighter,
fileContainer,
file,
Expand Down
6 changes: 3 additions & 3 deletions packages/diffs/src/components/FileDiff.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,7 @@ export class FileDiff<

// postpone background tokenizing to next frame for avoiding UI freeze
// during render
this.editor?.postponeBackgroundTokenizeToNextFrame();
this.editor?.__postponeBackgroundTokenizeToNextFrame();

const { collapsed = false, themeType = 'system' } = this.options;
const nextRenderRange = collapsed ? undefined : renderRange;
Expand Down Expand Up @@ -950,7 +950,7 @@ export class FileDiff<
const file = this.getAdditionFile();
if (editor != null && file != null) {
void this.hunksRenderer.initializeHighlighter().then((highlighter) => {
editor.syncToRenderedView(
editor.__resetEditState(
highlighter,
fileContainer,
file,
Expand Down Expand Up @@ -1008,7 +1008,7 @@ export class FileDiff<
const file = this.getAdditionFile();
if (fileContainer != null && file != null) {
void this.hunksRenderer.initializeHighlighter().then((highlighter) => {
editor.syncToRenderedView(
editor.__resetEditState(
highlighter,
fileContainer,
file,
Expand Down
Loading