Skip to content

[NO MERGE] [diffshub] Safari Example - No Highlighting #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
amadeus wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[NO MERGE] [diffshub] Safari Example - No Highlighting #768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/diffs/src/worker/WorkerPoolManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ import type {
} from './types';

const IGNORE_RESPONSE = Symbol('IGNORE_RESPONSE');
const DISABLE_HIGHLIGHTING = true;

class WorkerPoolTerminatedError extends Error {
constructor() {
Expand Down Expand Up @@ -559,6 +560,7 @@ export class WorkerPoolManager {
// attempt to highlight. This should be mostly never hit, but it's just an
// extra level of safety
if (
DISABLE_HIGHLIGHTING ||
isFilePlainText(file) ||
(cachedResult != null &&
areFileRenderOptionsEqual(
Expand All @@ -583,6 +585,7 @@ export class WorkerPoolManager {
const cachedResult = this.getFileResultCache(file);
const highlightKey = this.getFileHighlightKey(file);
if (
DISABLE_HIGHLIGHTING ||
highlightKey == null ||
isFilePlainText(file) ||
(cachedResult != null &&
Expand Down Expand Up @@ -628,6 +631,7 @@ export class WorkerPoolManager {
// attempt to highlight. This should be mostly never hit, but it's just an
// extra level of safety
if (
DISABLE_HIGHLIGHTING ||
isDiffPlainText(diff) ||
(cachedResult != null &&
areDiffRenderOptionsEqual(
Expand All @@ -652,6 +656,7 @@ export class WorkerPoolManager {
const cachedResult = this.getDiffResultCache(diff);
const highlightKey = this.getDiffHighlightKey(diff);
if (
DISABLE_HIGHLIGHTING ||
highlightKey == null ||
isDiffPlainText(diff) ||
(cachedResult != null &&
Expand Down
Loading