[diffs] fix pluralization of '0 unmodified lines'#694
Open
necolas wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
Might be worth applying this on the beta instead of stable, since i don't think we'll do a stable release before 1.2 at this point |
Contributor
|
Might not be worth it, but the More Official™ to do this would be: const enCardinalRules = new Intl.PluralRules("en-US"); // can cache this once
const pluralKey = enCardinalRules.select(lines);
if (pluralKey === 'one') {
return `${lines} unmodified line`;
} else if (pluralKey === 'other') {
return `${lines} unmodified lines`;
} else {
throw new Error(`Unexpected plural key: ${pluralKey}`);
} |
Member
|
@necolas do we still want to get this in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin