add piecepack_parser() alias and fix !PieceId bug#27
Merged
Conversation
* Export `piecepack_parser()` as an alias for `default_parser()`. * Fix `process_exclamation_move()` which was truncating the piece ID to a single character, causing `!PieceId` to fail for any PieceId longer than one character. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 86.92% 88.80% +1.87%
==========================================
Files 8 8
Lines 1224 1224
==========================================
+ Hits 1064 1087 +23
+ Misses 160 137 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat:
piecepack_parser()and fix !PieceId bugpiecepack_parser()as an alias fordefault_parser().process_exclamation_move()which was truncating the piece ID toa single character, causing
!PieceIdto fail for any PieceId longerthan one character.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
test: Add tests for all movetext parsers
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com