Skip to content

Add instructions how to sign a commit to contribution guidelines#1377

Open
yubiuser wants to merge 2 commits intomasterfrom
sign
Open

Add instructions how to sign a commit to contribution guidelines#1377
yubiuser wants to merge 2 commits intomasterfrom
sign

Conversation

@yubiuser
Copy link
Copy Markdown
Member

@yubiuser yubiuser commented May 3, 2026

What does this PR aim to accomplish?:

Adds basic instructions to the contribution guidelines on how to sign a commit. I always felt this could be an barrier to new contributors. I personally prefer ssh keys but this can be changed if you think we should go for gpg


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

yubiuser added 2 commits May 3, 2026 16:41
Signed-off-by: yubiuser <github@yubiuser.dev>
Assisted-by: Claude:claude-sonnet-4
Signed-off-by: yubiuser <github@yubiuser.dev>
@yubiuser yubiuser requested a review from a team as a code owner May 3, 2026 15:02
@netlify
Copy link
Copy Markdown

netlify Bot commented May 3, 2026

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit b05cd6c
🔍 Latest deploy log https://app.netlify.com/projects/pihole-docs/deploys/69f7637c092bea00086fd3a8
😎 Deploy Preview https://deploy-preview-1377--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@yubiuser yubiuser changed the title Sign Add instructions how to sign a commit to contribution guidelines May 3, 2026
@yubiuser yubiuser requested a review from PromoFaux May 7, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant