fix: improve sitemap generator for better Google Search Console compatibility#363
Merged
Merged
Conversation
|
@TechGenius-Karan is attempting to deploy a commit to the PhysicsHub's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
🎉 This PR is included in version 3.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📘 Pull Request Template – PhysicsHub
Thank you for contributing to PhysicsHub!
Please complete the sections below to help us review your pull request efficiently.
🔍 Description
Improves the sitemap generation script to resolve the Google Search Console
indexing issue (#107):
news,xhtml,image,video) that weredeclared but never used — these can confuse crawlers
<lastmod>dates to all URLs (blog, simulation, and static routes)<?xml version="1.0" encoding="UTF-8"?>declarationpath.join()+__dirnamefor correct cross-platform file pathspublic/directory exists before writing (defensive)out/directory handling usingexistsSync(removes dynamic imports)process.exit(1)on failure so CI fails visibly if sitemap errorsThis replicates the approach from PR #290 with Prettier formatting applied.
✅ Checklist
npm run format— Prettier passes on the changed file🎨 Visual Changes
No UI changes — build script only.
📂 Type of Change
🧩 Additional Notes for Reviewers
This is a re-implementation of PR #290 which the maintainer said would be merged
if prettier errors were fixed. Prettier has been applied and the file passes
npx prettier --check scripts/sitemap-generator.js. The current file alsoincludes the
simulationRoutes(added after #290 was opened), which have beengiven
lastmoddates as well.