Skip to content

fix: correct restitution label from Damping to Coefficient of restitution#361

Merged
mattqdev merged 1 commit into
physicshub:mainfrom
TechGenius-Karan:fix/restitution-label
Jun 22, 2026
Merged

fix: correct restitution label from Damping to Coefficient of restitution#361
mattqdev merged 1 commit into
physicshub:mainfrom
TechGenius-Karan:fix/restitution-label

Conversation

@TechGenius-Karan

Copy link
Copy Markdown
Contributor

🔍 Description

The restitution input field in the BallGravity and BouncingBall simulation control panels was
incorrectly labelled ζ - Damping:. This is wrong on two counts:

  • Wrong symbol: ζ (zeta) is the convention for the damping ratio in oscillatory systems (pendulums,
    spring-mass), not for collision elasticity.
  • Wrong concept: This parameter controls how much kinetic energy is preserved after a bounce — that is the
    coefficient of restitution (e), not damping. Damping describes continuous energy loss during motion;
    restitution describes the energy ratio across a discrete impact.

The CollisionSimulation config already correctly labels the same variable as e - Restitution: — this PR
makes BallGravity and BouncingBall consistent with it.

Closes #189


✅ Checklist

  • Verified that the project builds and runs locally (npm run dev)
  • Ensured no ESLint or TypeScript warnings/errors remain
  • Updated documentation, comments, or in-code explanations where needed
  • Verified responsiveness across devices (desktop, tablet, mobile)
  • Followed the CONTRIBUTING.md guidelines

🎨 Visual Changes (if UI-related)

This is a label-only change in the simulation control panel. The input behaviour, range, and step values are
unchanged.

Before:

ζ - Damping: (shown in BallGravity and BouncingBall control panels)

After:

e - Coefficient of restitution (0–1): (consistent with CollisionSimulation)


📂 Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📝 Documentation update
  • ♻️ Refactor / code quality improvement
  • 🎨 UI/UX enhancement
  • 🔒 Security improvement

🧩 Additional Notes for Reviewers

Only two lines changed across two config files — no logic, no range, no defaults touched:

  • app/(core)/data/configs/BallGravity.js line 60
  • app/(core)/data/configs/BouncingBall.js line 37## 🔍 Description

The restitution input field in the BallGravity and BouncingBall simulation control panels was
incorrectly labelled ζ - Damping:. This is wrong on two counts:

  • Wrong symbol: ζ (zeta) is the convention for the damping ratio in oscillatory systems (pendulums,
    spring-mass), not for collision elasticity.
  • Wrong concept: This parameter controls how much kinetic energy is preserved after a bounce — that is the
    coefficient of restitution (e), not damping. Damping describes continuous energy loss during motion;
    restitution describes the energy ratio across a discrete impact.

The CollisionSimulation config already correctly labels the same variable as e - Restitution: — this PR
makes BallGravity and BouncingBall consistent with it.

Closes #189


✅ Checklist

  • Verified that the project builds and runs locally (npm run dev)
  • Ensured no ESLint or TypeScript warnings/errors remain
  • Updated documentation, comments, or in-code explanations where needed
  • Verified responsiveness across devices (desktop, tablet, mobile)
  • Followed the CONTRIBUTING.md guidelines

🎨 Visual Changes (if UI-related)

This is a label-only change in the simulation control panel. The input behaviour, range, and step values are
unchanged.

Before:

ζ - Damping: (shown in BallGravity and BouncingBall control panels)

After:

e - Coefficient of restitution (0–1): (consistent with CollisionSimulation)


📂 Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📝 Documentation update
  • ♻️ Refactor / code quality improvement
  • 🎨 UI/UX enhancement
  • 🔒 Security improvement

🧩 Additional Notes for Reviewers

Only two lines changed across two config files — no logic, no range, no defaults touched:

  • app/(core)/data/configs/BallGravity.js line 60
  • app/(core)/data/configs/BouncingBall.js line 37
    Both changed from "ζ - Damping:""e - Coefficient of restitution (0–1):".

@vercel

vercel Bot commented Jun 22, 2026

Copy link
Copy Markdown

@TechGenius-Karan is attempting to deploy a commit to the PhysicsHub's projects Team on Vercel.

A member of the Team first needs to authorize it.

@mattqdev mattqdev merged commit fd15b83 into physicshub:main Jun 22, 2026
1 of 2 checks passed
@physicshub

Copy link
Copy Markdown
Owner

🎉 This PR is included in version 3.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Question]: Damping 1 is no energy loss?

3 participants