fix: correct restitution label from Damping to Coefficient of restitution#361
Merged
Merged
Conversation
|
@TechGenius-Karan is attempting to deploy a commit to the PhysicsHub's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
🎉 This PR is included in version 3.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Description
The
restitutioninput field in the BallGravity and BouncingBall simulation control panels wasincorrectly labelled
ζ - Damping:. This is wrong on two counts:ζ(zeta) is the convention for the damping ratio in oscillatory systems (pendulums,spring-mass), not for collision elasticity.
coefficient of restitution (
e), not damping. Damping describes continuous energy loss during motion;restitution describes the energy ratio across a discrete impact.
The
CollisionSimulationconfig already correctly labels the same variable ase - Restitution:— this PRmakes
BallGravityandBouncingBallconsistent with it.Closes #189
✅ Checklist
npm run dev)🎨 Visual Changes (if UI-related)
This is a label-only change in the simulation control panel. The input behaviour, range, and step values are
unchanged.
Before:
After:
📂 Type of Change
🧩 Additional Notes for Reviewers
Only two lines changed across two config files — no logic, no range, no defaults touched:
app/(core)/data/configs/BallGravity.jsline 60app/(core)/data/configs/BouncingBall.jsline 37## 🔍 DescriptionThe
restitutioninput field in the BallGravity and BouncingBall simulation control panels wasincorrectly labelled
ζ - Damping:. This is wrong on two counts:ζ(zeta) is the convention for the damping ratio in oscillatory systems (pendulums,spring-mass), not for collision elasticity.
coefficient of restitution (
e), not damping. Damping describes continuous energy loss during motion;restitution describes the energy ratio across a discrete impact.
The
CollisionSimulationconfig already correctly labels the same variable ase - Restitution:— this PRmakes
BallGravityandBouncingBallconsistent with it.Closes #189
✅ Checklist
npm run dev)🎨 Visual Changes (if UI-related)
This is a label-only change in the simulation control panel. The input behaviour, range, and step values are
unchanged.
Before:
After:
📂 Type of Change
🧩 Additional Notes for Reviewers
Only two lines changed across two config files — no logic, no range, no defaults touched:
app/(core)/data/configs/BallGravity.jsline 60app/(core)/data/configs/BouncingBall.jsline 37Both changed from
"ζ - Damping:"→"e - Coefficient of restitution (0–1):".