Revert "Stop copying zend_module_entry (#8551)"

[arnaud-lb]

This reverts commit b63df3c.

Fixes #9589

After all, copying the module entry was useful. This at least prevents overriding the module entry in case the module is loaded again in

php-src/ext/standard/dl.c

Lines 228 to 230 in ed0f1f0

	module_entry->type = type;
	module_entry->module_number = zend_next_free_module();
	module_entry->handle = handle;

[cmb69]

An alternative might be to catch double-loading of modules:

 ext/standard/dl.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/ext/standard/dl.c b/ext/standard/dl.c
index aae0996384..b8d1cbc78c 100644
--- a/ext/standard/dl.c
+++ b/ext/standard/dl.c
@@ -205,6 +205,10 @@ PHPAPI int php_load_extension(const char *filename, int type, int start_now)
 		return FAILURE;
 	}
 	module_entry = get_module();
+	if (zend_hash_str_exists(&module_registry, module_entry->name, strlen(module_entry->name))) {
+		zend_error(E_CORE_WARNING, "Module \"%s\" is already loaded", module_entry->name);
+		return FAILURE;
+	}
 	if (module_entry->zend_api != ZEND_MODULE_API_NO) {
 			php_error_docref(NULL, error_type,
 					"%s: Unable to initialize module\n"

[morrisonlevi]

I think detecting the double-load makes sense, even if we choose to revert this change for PHP 8.

[arnaud-lb]

@cmb69 do you want to pursue the double-load catching before RC4 ?

[cmb69]

@arnaud-lb, sure, I can do that. Will provide a PR shortly.