Skip to content

sockets ext for solaris update. - #8191

Closed
devnexen wants to merge 1 commit into
php:masterfrom
devnexen:solaris_socket_sol_filter
Closed

sockets ext for solaris update.#8191
devnexen wants to merge 1 commit into
php:masterfrom
devnexen:solaris_socket_sol_filter

Conversation

@devnexen

Copy link
Copy Markdown
Member

socket filter support, system can support up to 32 filters giving the possibility to retrive the full list.

@devnexen
devnexen force-pushed the solaris_socket_sol_filter branch from 5cfa497 to 8dd8262 Compare March 11, 2022 16:49
@cmb69

cmb69 commented Apr 4, 2022

Copy link
Copy Markdown
Member

Thanks, this looks like a reasonable addition (albeit only for Solaris). Do you happen to know any online documentation of this feature? That could be helpful for the doc team later.

@devnexen

devnexen commented Apr 4, 2022

Copy link
Copy Markdown
Member Author

ah good question, there is not really "documentation" about this only I stumbled across when I looked up solaris kernel modules then read illumos source code and this is how I knew about the 32 filters "limit" :-)

Comment thread ext/sockets/sockets.c Outdated
@cmb69

cmb69 commented Apr 4, 2022

Copy link
Copy Markdown
Member

Okay; I found some other info about SOL_FILTER and FIL_ATTACH.

@devnexen
devnexen force-pushed the solaris_socket_sol_filter branch from 8dd8262 to cfc35c3 Compare April 4, 2022 15:20
socket filter support, system can support up to 32 filters giving the possibility to retrive the full list.
@ramsey ramsey added this to the PHP 8.2 milestone May 25, 2022
@devnexen

Copy link
Copy Markdown
Member Author

@cmb69 does it looks ok ? :)

@cmb69 cmb69 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@devnexen devnexen closed this in 9090e26 Jul 25, 2022
adrian-enspired pushed a commit to adrian-enspired/php-src that referenced this pull request Aug 4, 2026
socket filter support, system can support up to 32 filters giving the possibility to retrive the full list.
Closes php#8191.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants