Skip to content

ext/snmp: Retry no-response test failures #23237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
LamentXU123 wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −42
Draft

ext/snmp: Retry no-response test failures #23237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e0c89a
ext/snmp: Put XFAILs under SKIPIF section
LamentXU123 Aug 12, 2026
2a2a24e
ext/snmp: Retry no-response test failures
LamentXU123 Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ext/snmp/tests/bug64124.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ if (@inet_ntop($packed) === false) {
die("skip no IPv6 support");
}
?>
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/bug64159.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ require_once(__DIR__.'/skipif.inc');
?>
--ENV--
MIBS=noneXistent
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/generic_timeout_error.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ snmp
<?php
require_once(__DIR__.'/skipif.inc');
?>
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/ipv6.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ if (@inet_ntop($packed) === false) {
die("skip no IPv6 support");
}
?>
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/snmp-object-errno-errstr.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ snmp
require_once(__DIR__.'/skipif.inc');
if (getenv('SKIP_ASAN')) die('skip Timeouts under ASAN');
?>
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/snmp-object.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ snmp
<?php
require_once(__DIR__.'/skipif.inc');
?>
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/snmp2_get.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ snmp
require_once(__DIR__.'/skipif.inc');
if (getenv('SKIP_ASAN')) die('skip Timeouts under ASAN');
?>
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/snmp2_getnext.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ snmp
<?php
require_once(__DIR__.'/skipif.inc');
?>
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/snmp2_real_walk.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ snmp
<?php
require_once(__DIR__.'/skipif.inc');
?>
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/snmp2_set-nomib.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ if (getenv('SKIP_ASAN')) die('skip Timeouts under ASAN');
?>
--ENV--
MIBS=
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/snmp2_set.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ snmp
<?php
require_once(__DIR__.'/skipif.inc');
?>
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/snmp2_walk.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ snmp
require_once(__DIR__.'/skipif.inc');
if (getenv('SKIP_ASAN')) die('skip Timeouts under ASAN');
?>
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/snmp3-error.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ snmp
require_once(__DIR__.'/skipif.inc');
if (getenv('SKIP_ASAN')) die('skip Timeouts under ASAN');
?>
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/snmp3.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ snmp
<?php
require_once(__DIR__.'/skipif.inc');
?>
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/snmp_getvalue.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ snmp
require_once(__DIR__.'/skipif.inc');
if (getenv('SKIP_ASAN')) die('skip Timeouts under ASAN');
?>
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/snmpget.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ snmp
require_once(__DIR__.'/skipif.inc');
if (getenv('SKIP_ASAN')) die('skip Timeouts under ASAN');
?>
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/snmpgetnext.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ snmp
<?php
require_once(__DIR__.'/skipif.inc');
?>
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/snmprealwalk.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ snmp
<?php
require_once(__DIR__.'/skipif.inc');
?>
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/snmpset-nomib.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ if (getenv('SKIP_ASAN')) die('skip Timeouts under ASAN');
?>
--ENV--
MIBS=
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/snmpset.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ snmp
<?php
require_once(__DIR__.'/skipif.inc');
?>
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
2 changes: 0 additions & 2 deletions ext/snmp/tests/snmpwalk.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ snmp
require_once(__DIR__.'/skipif.inc');
if (getenv('SKIP_ASAN')) die('skip Timeouts under ASAN');
?>
--XFAIL--
SNMP tests might possibly fail on Windows
--FILE--
<?php
require_once(__DIR__.'/snmp_include.inc');
Expand Down
1 change: 1 addition & 0 deletions run-tests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3124,6 +3124,7 @@ function is_flaky_output(string $output): bool
'connection refused',
'deadlock',
'mailbox already exists',
'no response from',

@NickSdot NickSdot Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a comment why it was added? Harder to follow via git history. Ideally the list shrinks to zero later; most of it sounds like concurrency stuff which we eventually might rather want to find root causes instead of adding retry overhead.

'timed out',
];
$regex = '(\b(' . implode('|', $messages) . ')\b)i';
Expand Down
Loading