Skip to content

ext/gettext/tests: updates for musl-1.2.6 #23235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
orlitzky wants to merge 1 commit into from
+11 −4
Closed

ext/gettext/tests: updates for musl-1.2.6 #23235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ext/gettext/tests/bug53251.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,21 @@ $expected = [true, true, false, "UTF-8", "UTF-8"];
// "foo" is unbound, so in the first call, you will get false instead
// of a string.
//
// bind_textdomain_codeset() always returns false on musl
// because musl only supports UTF-8. For more information:
// Prior to v1.2.6, bind_textdomain_codeset() always returns false on
// musl because musl only supports UTF-8. For more information:
//
// * https://github.com/php/doc-en/issues/4311,
// * https://github.com/php/php-src/issues/17163
//
$expected_musl = [false, true, false, false, false];

var_dump($results === $expected || $results === $expected_musl);
// As of v1.2.6, bind_textdomain_codeset() returns "UTF-8" in all
// three cases on musl because UTF-8 is the only supported codeset.
$expected_musl126 = [false, true, "UTF-8", "UTF-8", "UTF-8"];

var_dump($results === $expected
|| $results === $expected_musl
|| $results === $expected_musl126);
?>
--EXPECT--
bool(true)
3 changes: 2 additions & 1 deletion ext/gettext/tests/gettext_bind_textdomain_codeset-retval.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@ gettext
}

// bind_textdomain_codeset() always returns false on musl
// because musl only supports UTF-8. For more information:
// prior to v1.2.6. For more information:
//
// * https://github.com/php/doc-en/issues/4311,
// * https://github.com/php/php-src/issues/17163
//
// As of v1.2.6, it returns "UTF-8" as well.
$result = bind_textdomain_codeset('messages', "UTF-8");
var_dump($result === false || $result === "UTF-8");

Expand Down
Loading