Fix GH-23120 test on Windows x86 - #23180
Merged
shivammathur merged 1 commit intoAug 9, 2026
Merged
Conversation
devnexen
approved these changes
Aug 9, 2026
shivammathur
added a commit
to shivammathur/php-src
that referenced
this pull request
Aug 9, 2026
* PHP-8.5: Fix phpGH-23120 test on Windows x86 (php#23180)
pull Bot
pushed a commit
to dolfly/php-src
that referenced
this pull request
Aug 9, 2026
* PHP-8.4: Fix phpGH-23120 test on Windows x86 (php#23180)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to GH-23120.
Nightly CI on Windows x86 fails
ext/dom/tests/gh23120.phpt.https://github.com/php/php-src/actions/runs/31288567288/job/93181841779#step:6:379
Comparing 10,000 nested nodes does not exhaust the 512K stack limit on Windows x86. Reducing it to 256K should consistently trigger the stack guard across architectures.