ext/dom: Do not recursively normalize descendant elements - #23139
Closed
LamentXU123 wants to merge 2 commits into
Closed
ext/dom: Do not recursively normalize descendant elements#23139LamentXU123 wants to merge 2 commits into
LamentXU123 wants to merge 2 commits into
Conversation
Member
|
there is a PR already. |
Member
Author
|
Oh I see. Wasn't aware when I started to work on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#23117 and #23116 are basically a same bug. DOMNode::normalize() and Dom\Node::normalize() recursively normalized descendant elements. Deeply nested trees could therefore exhaust the C stack.
We already have helpers to solve this. These two functions are using legacy implementations, so just update the helper can solve this.
Closes GH-23116.
Closes GH-23117.