Skip to content

date: Correctly handle Duration::__construct() calls #23098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimWolla merged 1 commit into from
Aug 7, 2026
+14 −0
Merged

date: Correctly handle Duration::__construct() calls #23098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ext/date/tests/time/duration/readonly.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,16 @@ echo "====", PHP_EOL;

var_dump((new ReflectionProperty($d, 'seconds'))->isWritable(null, $d));

echo "====", PHP_EOL;

try {
(new ReflectionMethod($d, '__construct'))->invoke($d);
} catch (Throwable $e) {
echo $e::class, ': ', $e->getMessage(), PHP_EOL;
}

echo f($d), PHP_EOL;

?>
--EXPECT--
Error: Cannot modify readonly property Time\Duration::$seconds
Expand All @@ -112,3 +122,6 @@ Error: Cannot modify readonly property Time\Duration::$seconds
Error: Cannot modify protected(set) readonly property Time\Duration::$seconds from global scope
====
bool(false)
====
Error: Cannot directly construct Time\Duration, use Time\Duration::from*() methods instead
+1.000000000
1 change: 1 addition & 0 deletions ext/date/time_duration.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ ZEND_ATTRIBUTE_NODISCARD static zend_result create_duration(zval *target, zend_u

PHP_METHOD(Time_Duration, __construct)
{
zend_throw_error(NULL, "Cannot directly construct Time\\Duration, use Time\\Duration::from*() methods instead");
}

PHP_METHOD(Time_Duration, fromSeconds)
Expand Down
Loading