Implement 8.6 deprecations - #23074
Merged
Merged
Conversation
Sjord
reviewed
Aug 6, 2026
Sjord
reviewed
Aug 6, 2026
Sjord
reviewed
Aug 6, 2026
TimWolla
reviewed
Aug 6, 2026
Girgias
force-pushed
the
2026-08-8.6-deprecations
branch
from
August 6, 2026 17:28
96c961e to
95cd7c5
Compare
TimWolla
reviewed
Aug 6, 2026
| throw new Exception($message); | ||
| }); | ||
|
|
||
| /* Throwing error handlers do no apply for compile time deprecations */ |
Member
There was a problem hiding this comment.
Does wrapping the function into if(random_int(1, 1)) work? Otherwise you could require __DIR__ . '/readonly_as_fn_name_is_deprecated.phpt'; to reuse the other test.
Member
Author
There was a problem hiding this comment.
No, it doesn't do anything.
Fix tests using non canonical versions and improve existing tests. RFC: - https://wiki.php.net/rfc/deprecations_php_8_6#deprecate_is_double - https://wiki.php.net/rfc/deprecations_php_8_6#deprecate_is_integer - https://wiki.php.net/rfc/deprecations_php_8_6#deprecate_is_long - https://wiki.php.net/rfc/deprecations_php_8_6#deprecate_doubleval
Girgias
force-pushed
the
2026-08-8.6-deprecations
branch
from
August 9, 2026 20:37
95cd7c5 to
b36f51d
Compare
Girgias
force-pushed
the
2026-08-8.6-deprecations
branch
from
August 9, 2026 20:52
b36f51d to
bca9332
Compare
Girgias
marked this pull request as ready for review
August 9, 2026 23:00
Girgias
requested review from
alexdowad,
bukka,
derickr,
devnexen,
dstogov,
kocsismate and
youkidearitai
as code owners
August 9, 2026 23:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/deprecations_php_8_6