Skip to content

Zend: mark zend_unfinished_calls_gc() as static - #23012

Merged
Girgias merged 1 commit into
php:masterfrom
Girgias:zend_unfinished_calls_gc-private
Aug 10, 2026
Merged

Zend: mark zend_unfinished_calls_gc() as static#23012
Girgias merged 1 commit into
php:masterfrom
Girgias:zend_unfinished_calls_gc-private

Conversation

@Girgias

@Girgias Girgias commented Aug 4, 2026

Copy link
Copy Markdown
Member

It is only used once internally by zend_execute.c, as shown by a SourceGraph search. [1]

[1] https://sourcegraph.com/search?q=context:global+-f:zend_execute.c+-f:zend_execute.h+zend_unfinished_calls_gc&patternType=keyword&sm=0

@DanielEScherzer DanielEScherzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no valid hits in sourcegraph, but should have UPGRADING.INTERNALS

@Girgias
Girgias requested a review from iluuu1994 August 4, 2026 20:02
@Girgias
Girgias merged commit b645104 into php:master Aug 10, 2026
18 checks passed
@Girgias
Girgias deleted the zend_unfinished_calls_gc-private branch August 10, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants