Clarify usage of @deprecated annotation in stubs - #19562
Merged
Merged
Conversation
Girgias
marked this pull request as ready for review
August 23, 2025 12:33
DanielEScherzer
left a comment
DanielEScherzer
left a comment
Member
There was a problem hiding this comment.
Overall makes sense, small issue inline
Member
There was a problem hiding this comment.
there wasn't an 8.4.0 release, it got skipped and we went with 8.4.1 - maybe just say "8.4"?
And if you do switch to "8.4", then below should use "8.5" for consistency
Member
Author
There was a problem hiding this comment.
The thing is for @genstubs-expose-comment-block it says that the feature is only available since 8.4.0.
So I reformatted all of them to get rid of the final .0
To indicate that this was used prior to the \Deprecated attribute being usable on those symbols.
Girgias
force-pushed
the
stubs-docs-fixes
branch
from
August 24, 2025 09:41
42472bc to
eb5ec1c
Compare
DanielEScherzer
approved these changes
Aug 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To indicate that this was used prior to the \Deprecated attribute being usable on those symbols.