Throw ValueError when a wrong flag value is provided to the second argument of scandir() - #19373
Merged
alexandre-daubois merged 2 commits intoApr 10, 2026
Merged
Conversation
Girgias
reviewed
Aug 6, 2025
alexandre-daubois
force-pushed
the
scandir-wrong-flags
branch
from
August 6, 2025 14:11
1e5d5bf to
503b9a9
Compare
Member
|
No longer requires an RFC with the policy change, could you rebase? |
alexandre-daubois
force-pushed
the
scandir-wrong-flags
branch
2 times, most recently
from
April 8, 2026 12:16
4dd8b1e to
8ff8767
Compare
Girgias
reviewed
Apr 8, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Will need NEWS entry yes because that's apparently what we are doing now.
alexandre-daubois
requested review from
SakiTakamachi,
TimWolla,
adoy,
arnaud-lb,
derickr,
devnexen,
dstogov,
kocsismate and
ndossche
as code owners
April 8, 2026 12:17
alexandre-daubois
force-pushed
the
scandir-wrong-flags
branch
2 times, most recently
from
April 8, 2026 12:19
d47a4d9 to
aa8ce38
Compare
Member
Author
|
I have my answer 😄 |
…gument of `scandir()`
alexandre-daubois
force-pushed
the
scandir-wrong-flags
branch
from
April 8, 2026 12:23
aa8ce38 to
632b4ec
Compare
Girgias
approved these changes
Apr 8, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Still requires an UPGRADING entry ideally :)
…gument of `scandir()`
alexandre-daubois
force-pushed
the
scandir-wrong-flags
branch
from
April 8, 2026 16:59
632b4ec to
437a0e1
Compare
Member
Author
|
Ah yes, makes sense now that it targets master. I also removed the entry from https://wiki.php.net/rfc/deprecations_php_8_6 |
Girgias
approved these changes
Apr 9, 2026
adrian-enspired
pushed a commit
to adrian-enspired/php-src
that referenced
this pull request
Aug 4, 2026
…gument of `scandir()` (php#19373)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://wiki.php.net/rfc/deprecations_php_8_6Not anymore with the new policy