Skip to content

Fix: php 8.6 compatibility #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henderkes merged 1 commit into from
Aug 13, 2026
+8 −0
Merged

Fix: php 8.6 compatibility #2600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions frankenphp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,10 +586,18 @@ static int frankenphp_worker_request_startup() {
sizeof(SAPI_PHP_VERSION_HEADER) - 1, 1);
}

/* PG(output_handler) is a char* before PHP 8.6, a zend_string* since */
#if PHP_VERSION_ID < 80600
if (PG(output_handler) && PG(output_handler)[0]) {
zval oh;

ZVAL_STRING(&oh, PG(output_handler));
#else
if (PG(output_handler) && ZSTR_LEN(PG(output_handler))) {
zval oh;

ZVAL_STR(&oh, zend_string_dup(PG(output_handler), false));
#endif
php_output_start_user(&oh, 0, PHP_OUTPUT_HANDLER_STDFLAGS);
zval_ptr_dtor(&oh);
} else if (PG(output_buffering)) {
Expand Down
Loading